evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Escape media_content_id in media player proxy (#77811)

Browse source 
* Escape media_content_id in media player proxy

* Change usage in kodi

* Change usage in roku

* Change usage in sonos

* Add test

* Add comment

* Change path regex instead of double quoting

* Use .+ instead of .*
This commit is contained in:
uvjustin 2022-09-09 19:18:24 +08:00 • committed by GitHub
parent c3b2e03ce8
commit 9b2d17cd00
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 43 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

31
tests/components/media_player/test_init.py
View file

@ -280,3 +280,34 @@ async def test_enqueue_alert_exclusive(hass):
},
blocking=True,
)
async def test_get_async_get_browse_image_quoting(
hass, hass_client_no_auth, hass_ws_client
):
"""Test get browse image using media_content_id with special characters.
async_get_browse_image() should get called with the same string that is
passed into get_browse_image_url().
"""
await async_setup_component(
hass, "media_player", {"media_player": {"platform": "demo"}}
)
await hass.async_block_till_done()
entity_comp = hass.data.get("entity_components", {}).get("media_player")
assert entity_comp
player = entity_comp.get_entity("media_player.bedroom")
assert player
client = await hass_client_no_auth()
with patch(
"homeassistant.components.media_player.MediaPlayerEntity."
"async_get_browse_image",
) as mock_browse_image:
media_content_id = "a/b c/d+e%2Fg{}"
url = player.get_browse_image_url("album", media_content_id)
await client.get(url)
mock_browse_image.assert_called_with("album", media_content_id, None)