evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Handle battery services that only report low battery in HomeKit Controller (#79072)

Browse source
This commit is contained in:
J. Nick Koston 2022-09-25 12:08:28 -10:00 • committed by GitHub
parent b70027aec1
commit 917cf674de
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 485 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
homeassistant/components/homekit_controller/sensor.py
View file

@ -410,6 +410,7 @@ class HomeKitBatterySensor(HomeKitSensor):
_attr_device_class = SensorDeviceClass.BATTERY
_attr_native_unit_of_measurement = PERCENTAGE
_attr_entity_category = EntityCategory.DIAGNOSTIC
def get_characteristic_types(self) -> list[str]:
"""Define the homekit characteristics the entity is tracking."""
@ -517,6 +518,11 @@ ENTITY_TYPES = {
ServicesTypes.BATTERY_SERVICE: HomeKitBatterySensor,
}
# Only create the entity if it has the required characteristic
REQUIRED_CHAR_BY_TYPE = {
ServicesTypes.BATTERY_SERVICE: CharacteristicsTypes.BATTERY_LEVEL,
}
async def async_setup_entry(
hass: HomeAssistant,
@ -531,6 +537,10 @@ async def async_setup_entry(
def async_add_service(service: Service) -> bool:
if not (entity_class := ENTITY_TYPES.get(service.type)):
return False
if (
required_char := REQUIRED_CHAR_BY_TYPE.get(service.type)
) and not service.has(required_char):
return False
info = {"aid": service.accessory.aid, "iid": service.iid}
async_add_entities([entity_class(conn, info)], True)
return True