diff --git a/homeassistant/components/upnp.py b/homeassistant/components/upnp.py index a058fdae85e..355a6d0a648 100644 --- a/homeassistant/components/upnp.py +++ b/homeassistant/components/upnp.py @@ -9,6 +9,8 @@ from urllib.parse import urlsplit import voluptuous as vol +import homeassistant.loader as loader + from homeassistant.const import (EVENT_HOMEASSISTANT_STOP) from homeassistant.helpers import config_validation as cv from homeassistant.helpers import discovery @@ -23,8 +25,12 @@ DOMAIN = 'upnp' DATA_UPNP = 'UPNP' CONF_ENABLE_PORT_MAPPING = 'port_mapping' +CONF_EXTERNAL_PORT = 'external_port' CONF_UNITS = 'unit' +NOTIFICATION_ID = 'upnp_notification' +NOTIFICATION_TITLE = 'UPnP Setup' + UNITS = { "Bytes": 1, "KBytes": 1024, @@ -35,6 +41,7 @@ UNITS = { CONFIG_SCHEMA = vol.Schema({ DOMAIN: vol.Schema({ vol.Optional(CONF_ENABLE_PORT_MAPPING, default=True): cv.boolean, + vol.Optional(CONF_EXTERNAL_PORT, default=0): cv.positive_int, vol.Optional(CONF_UNITS, default="MBytes"): vol.In(UNITS), }), }, extra=vol.ALLOW_EXTRA) @@ -65,15 +72,33 @@ def setup(hass, config): base_url = urlsplit(hass.config.api.base_url) host = base_url.hostname - external_port = internal_port = base_url.port + internal_port = base_url.port + external_port = int(config[DOMAIN].get(CONF_EXTERNAL_PORT)) - upnp.addportmapping( - external_port, 'TCP', host, internal_port, 'Home Assistant', '') + if external_port == 0: + external_port = internal_port - def deregister_port(event): - """De-register the UPnP port mapping.""" - upnp.deleteportmapping(hass.config.api.port, 'TCP') + persistent_notification = loader.get_component('persistent_notification') - hass.bus.listen_once(EVENT_HOMEASSISTANT_STOP, deregister_port) + try: + upnp.addportmapping( + external_port, 'TCP', host, internal_port, 'Home Assistant', '') + def deregister_port(event): + """De-register the UPnP port mapping.""" + upnp.deleteportmapping(external_port, 'TCP') + + hass.bus.listen_once(EVENT_HOMEASSISTANT_STOP, deregister_port) + + except Exception as ex: + _LOGGER.error("UPnP failed to configure port mapping: %s", str(ex)) + persistent_notification.create( + hass, 'ERROR: tcp port {} is already mapped in your router.' + '
Please disable port_mapping in the upnp ' + 'configuration section.
' + 'You will need to restart hass after fixing.' + ''.format(external_port), + title=NOTIFICATION_TITLE, + notification_id=NOTIFICATION_ID) + return False return True