evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add automation config validation

Browse source 
* Add automation config validation

* Remove unnecessary dict validator

* Downgrade voluptuous to 0.8.9

* Fix linting

* Address issues
This commit is contained in:
Paulus Schoutsen 2016-04-04 12:18:58 -07:00
parent cbe9a7d2a3
commit 8ef542927f
24 changed files with 570 additions and 443 deletions
Download patch file Download diff file Expand all files Collapse all files

38
tests/components/automation/test_init.py
View file

@ -1,6 +1,7 @@
"""The tests for the automation component."""
import unittest
from homeassistant.bootstrap import _setup_component
import homeassistant.components.automation as automation
from homeassistant.const import ATTR_ENTITY_ID
@ -13,6 +14,7 @@ class TestAutomation(unittest.TestCase):
def setUp(self): # pylint: disable=invalid-name
"""Setup things to be run when tests are started."""
self.hass = get_test_home_assistant()
self.hass.config.components.append('group')
self.calls = []
def record_call(service):
@ -26,7 +28,7 @@ class TestAutomation(unittest.TestCase):
def test_service_data_not_a_dict(self):
"""Test service data not dict."""
automation.setup(self.hass, {
assert not _setup_component(self.hass, automation.DOMAIN, {
automation.DOMAIN: {
'trigger': {
'platform': 'event',
@ -39,13 +41,9 @@ class TestAutomation(unittest.TestCase):
}
})
self.hass.bus.fire('test_event')
self.hass.pool.block_till_done()
self.assertEqual(1, len(self.calls))
def test_service_specify_data(self):
"""Test service data."""
automation.setup(self.hass, {
assert _setup_component(self.hass, automation.DOMAIN, {
automation.DOMAIN: {
'trigger': {
'platform': 'event',
@ -65,7 +63,7 @@ class TestAutomation(unittest.TestCase):
def test_service_specify_entity_id(self):
"""Test service data."""
automation.setup(self.hass, {
assert _setup_component(self.hass, automation.DOMAIN, {
automation.DOMAIN: {
'trigger': {
'platform': 'event',
@ -86,7 +84,7 @@ class TestAutomation(unittest.TestCase):
def test_service_specify_entity_id_list(self):
"""Test service data."""
automation.setup(self.hass, {
assert _setup_component(self.hass, automation.DOMAIN, {
automation.DOMAIN: {
'trigger': {
'platform': 'event',
@ -107,7 +105,7 @@ class TestAutomation(unittest.TestCase):
def test_two_triggers(self):
"""Test triggers."""
automation.setup(self.hass, {
assert _setup_component(self.hass, automation.DOMAIN, {
automation.DOMAIN: {
'trigger': [
{
@ -135,7 +133,7 @@ class TestAutomation(unittest.TestCase):
def test_two_conditions_with_and(self):
"""Test two and conditions."""
entity_id = 'test.entity'
automation.setup(self.hass, {
assert _setup_component(self.hass, automation.DOMAIN, {
automation.DOMAIN: {
'trigger': [
{
@ -147,7 +145,7 @@ class TestAutomation(unittest.TestCase):
{
'platform': 'state',
'entity_id': entity_id,
'state': 100
'state': '100'
},
{
'platform': 'numeric_state',
@ -179,7 +177,7 @@ class TestAutomation(unittest.TestCase):
def test_two_conditions_with_or(self):
"""Test two or conditions."""
entity_id = 'test.entity'
automation.setup(self.hass, {
assert _setup_component(self.hass, automation.DOMAIN, {
automation.DOMAIN: {
'trigger': [
{
@ -192,7 +190,7 @@ class TestAutomation(unittest.TestCase):
{
'platform': 'state',
'entity_id': entity_id,
'state': 200
'state': '200'
},
{
'platform': 'numeric_state',
@ -224,13 +222,13 @@ class TestAutomation(unittest.TestCase):
def test_using_trigger_as_condition(self):
"""Test triggers as condition."""
entity_id = 'test.entity'
automation.setup(self.hass, {
assert _setup_component(self.hass, automation.DOMAIN, {
automation.DOMAIN: {
'trigger': [
{
'platform': 'state',
'entity_id': entity_id,
'state': 100
'state': '100'
},
{
'platform': 'numeric_state',
@ -247,21 +245,21 @@ class TestAutomation(unittest.TestCase):
self.hass.states.set(entity_id, 100)
self.hass.pool.block_till_done()
self.assertEqual(1, len(self.calls))
self.assertEqual(2, len(self.calls))
self.hass.states.set(entity_id, 120)
self.hass.pool.block_till_done()
self.assertEqual(1, len(self.calls))
self.assertEqual(2, len(self.calls))
self.hass.states.set(entity_id, 151)
self.hass.pool.block_till_done()
self.assertEqual(1, len(self.calls))
self.assertEqual(2, len(self.calls))
def test_using_trigger_as_condition_with_invalid_condition(self):
"""Event is not a valid condition."""
entity_id = 'test.entity'
self.hass.states.set(entity_id, 100)
automation.setup(self.hass, {
assert _setup_component(self.hass, automation.DOMAIN, {
automation.DOMAIN: {
'trigger': [
{
@ -287,7 +285,7 @@ class TestAutomation(unittest.TestCase):
def test_automation_list_setting(self):
"""Event is not a valid condition."""
self.assertTrue(automation.setup(self.hass, {
self.assertTrue(_setup_component(self.hass, automation.DOMAIN, {
automation.DOMAIN: [{
'trigger': {
'platform': 'event',