[powerwall] Skip backup reserve sensor if data is unavailable (#69637)
This commit is contained in:
parent
261e12e881
commit
8c00fde27d
4 changed files with 39 additions and 5 deletions
|
@ -223,13 +223,18 @@ def call_base_info(power_wall: Powerwall, host: str) -> PowerwallBaseInfo:
|
|||
|
||||
def _fetch_powerwall_data(power_wall: Powerwall) -> PowerwallData:
|
||||
"""Process and update powerwall data."""
|
||||
try:
|
||||
backup_reserve = power_wall.get_backup_reserve_percentage()
|
||||
except MissingAttributeError:
|
||||
backup_reserve = None
|
||||
|
||||
return PowerwallData(
|
||||
charge=power_wall.get_charge(),
|
||||
site_master=power_wall.get_sitemaster(),
|
||||
meters=power_wall.get_meters(),
|
||||
grid_services_active=power_wall.is_grid_services_active(),
|
||||
grid_status=power_wall.get_grid_status(),
|
||||
backup_reserve=power_wall.get_backup_reserve_percentage(),
|
||||
backup_reserve=backup_reserve,
|
||||
)
|
||||
|
||||
|
||||
|
|
|
@ -38,7 +38,7 @@ class PowerwallData:
|
|||
meters: MetersAggregates
|
||||
grid_services_active: bool
|
||||
grid_status: GridStatus
|
||||
backup_reserve: float
|
||||
backup_reserve: float | None
|
||||
|
||||
|
||||
class PowerwallRuntimeData(TypedDict):
|
||||
|
|
|
@ -117,9 +117,11 @@ async def async_setup_entry(
|
|||
data: PowerwallData = coordinator.data
|
||||
entities: list[PowerWallEntity] = [
|
||||
PowerWallChargeSensor(powerwall_data),
|
||||
PowerWallBackupReserveSensor(powerwall_data),
|
||||
]
|
||||
|
||||
if data.backup_reserve is not None:
|
||||
entities.append(PowerWallBackupReserveSensor(powerwall_data))
|
||||
|
||||
for meter in data.meters.meters:
|
||||
entities.append(PowerWallExportSensor(powerwall_data, meter))
|
||||
entities.append(PowerWallImportSensor(powerwall_data, meter))
|
||||
|
@ -190,8 +192,10 @@ class PowerWallBackupReserveSensor(PowerWallEntity, SensorEntity):
|
|||
return f"{self.base_unique_id}_backup_reserve"
|
||||
|
||||
@property
|
||||
def native_value(self) -> int:
|
||||
def native_value(self) -> int | None:
|
||||
"""Get the current value in percentage."""
|
||||
if self.data.backup_reserve is None:
|
||||
return None
|
||||
return round(self.data.backup_reserve)
|
||||
|
||||
|
||||
|
|
|
@ -1,5 +1,7 @@
|
|||
"""The sensor tests for the powerwall platform."""
|
||||
from unittest.mock import patch
|
||||
from unittest.mock import Mock, patch
|
||||
|
||||
from tesla_powerwall.error import MissingAttributeError
|
||||
|
||||
from homeassistant.components.powerwall.const import DOMAIN
|
||||
from homeassistant.components.sensor import ATTR_STATE_CLASS
|
||||
|
@ -112,3 +114,26 @@ async def test_sensors(hass, entity_registry_enabled_by_default):
|
|||
# HA changes the implementation and a new one appears
|
||||
for key, value in expected_attributes.items():
|
||||
assert state.attributes[key] == value
|
||||
|
||||
|
||||
async def test_sensor_backup_reserve_unavailable(hass):
|
||||
"""Confirm that backup reserve sensor is not added if data is unavailable from the device."""
|
||||
|
||||
mock_powerwall = await _mock_powerwall_with_fixtures(hass)
|
||||
mock_powerwall.get_backup_reserve_percentage = Mock(
|
||||
side_effect=MissingAttributeError(Mock(), "backup_reserve_percent", "operation")
|
||||
)
|
||||
|
||||
config_entry = MockConfigEntry(domain=DOMAIN, data={CONF_IP_ADDRESS: "1.2.3.4"})
|
||||
config_entry.add_to_hass(hass)
|
||||
with patch(
|
||||
"homeassistant.components.powerwall.config_flow.Powerwall",
|
||||
return_value=mock_powerwall,
|
||||
), patch(
|
||||
"homeassistant.components.powerwall.Powerwall", return_value=mock_powerwall
|
||||
):
|
||||
assert await hass.config_entries.async_setup(config_entry.entry_id)
|
||||
await hass.async_block_till_done()
|
||||
|
||||
state = hass.states.get("sensor.powerwall_backup_reserve")
|
||||
assert state is None
|
||||
|
|
Loading…
Add table
Reference in a new issue