evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add proper support for zwave_js Indicator CC (#90248)

Browse source 
* Add proper support for zwave_js Indicator CC

* remove stale test

* Make all indicators diagnostic

* only set entity category if it is specified

* Only set properties from discovery if specified

* Conditionally set assumed state as well

* fix const name

* Don't create task

* Disable property keys 3-5 by default

* add additional dispatcher_connects so we catch all signals

* be consistent about order

* rename new discovery parameter

* comment

* exclude property keys 3-5

* fix remove logic

* add comment so I don't forget

* Switch entity category to config where necessary

* cut line

* less lines

* Update homeassistant/components/zwave_js/switch.py

Co-authored-by: kpine <keith.pine@gmail.com>

* Move async_remove to respond to interview started event

* Set up listener immediately so we don't wait for platform creation

* remove dupe import

* black

* append

---------

Co-authored-by: kpine <keith.pine@gmail.com>
This commit is contained in:
Raman Gupta 2023-05-24 09:09:38 -04:00 • committed by GitHub
parent 66f7218b68
commit 872cd47e87
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
16 changed files with 1862 additions and 80 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/components/zwave_js/test_diagnostics.py
View file

@ -122,7 +122,7 @@ async def test_device_diagnostics_missing_primary_value(
integration,
hass_client: ClientSessionGenerator,
) -> None:
"""Test that the device diagnostics handles an entity with a missing primary value."""
"""Test that device diagnostics handles an entity with a missing primary value."""
dev_reg = async_get_dev_reg(hass)
device = dev_reg.async_get_device({get_device_id(client.driver, multisensor_6)})
assert device