Add address to error text in modbus (#104520)

This commit is contained in:
jan iversen 2023-11-25 21:28:49 +01:00 committed by GitHub
parent fc5ae50e06
commit 86b172037b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -435,16 +435,24 @@ class ModbusHub:
try: try:
result: ModbusResponse = entry.func(address, value, **kwargs) result: ModbusResponse = entry.func(address, value, **kwargs)
except ModbusException as exception_error: except ModbusException as exception_error:
self._log_error(str(exception_error)) error = (
f"Error: device: {slave} address: {address} -> {str(exception_error)}"
)
self._log_error(error)
return None return None
if not result: if not result:
self._log_error("Error: pymodbus returned None") error = (
f"Error: device: {slave} address: {address} -> pymodbus returned None"
)
self._log_error(error)
return None return None
if not hasattr(result, entry.attr): if not hasattr(result, entry.attr):
self._log_error(str(result)) error = f"Error: device: {slave} address: {address} -> {str(result)}"
self._log_error(error)
return None return None
if result.isError(): if result.isError():
self._log_error("Error: pymodbus returned isError True") error = f"Error: device: {slave} address: {address} -> pymodbus returned isError True"
self._log_error(error)
return None return None
self._in_error = False self._in_error = False
return result return result