Add tests to Lidarr (#79610)

* Add tests to Lidarr

* fix js files

* take out the trash

* fix 3.9

* uno mas

* fix fixture

* ruff

* Update const.py

---------

Co-authored-by: Erik Montnemery <erik@montnemery.com>

tests/components/lidarr/test_config_flow.py

@@ -1,138 +1,104 @@
 """Test Lidarr config flow."""
-from unittest.mock import patch
-
-from aiopyarr import exceptions
-
 from homeassistant import data_entry_flow
 from homeassistant.components.lidarr.const import DEFAULT_NAME, DOMAIN
 from homeassistant.config_entries import SOURCE_REAUTH, SOURCE_USER
 from homeassistant.const import CONF_API_KEY, CONF_SOURCE
 from homeassistant.core import HomeAssistant
 
-from . import API_KEY, CONF_DATA, MOCK_USER_INPUT, create_entry, mock_connection
-
-from tests.test_util.aiohttp import AiohttpClientMocker
+from .conftest import CONF_DATA, MOCK_INPUT, ComponentSetup
 
 
-def _patch_client():
-    return patch(
-        "homeassistant.components.lidarr.config_flow.LidarrClient.async_get_system_status"
-    )
-
-
-async def test_flow_user_form(
-    hass: HomeAssistant, aioclient_mock: AiohttpClientMocker
-) -> None:
+async def test_flow_user_form(hass: HomeAssistant, connection) -> None:
     """Test that the user set up form is served."""
-    mock_connection(aioclient_mock)
     result = await hass.config_entries.flow.async_init(
         DOMAIN,
         context={CONF_SOURCE: SOURCE_USER},
     )
-    with patch(
-        "homeassistant.components.lidarr.config_flow.LidarrClient.async_try_zeroconf",
-        return_value=("/api/v3", API_KEY, ""),
-    ):
-        result = await hass.config_entries.flow.async_configure(
-            result["flow_id"],
-            user_input=MOCK_USER_INPUT,
-        )
+
+    assert result["type"] == data_entry_flow.RESULT_TYPE_FORM
+    assert result["step_id"] == "user"
+
+    result = await hass.config_entries.flow.async_configure(
+        result["flow_id"],
+        user_input=MOCK_INPUT,
+    )
     assert result["type"] == data_entry_flow.RESULT_TYPE_CREATE_ENTRY
     assert result["title"] == DEFAULT_NAME
     assert result["data"] == CONF_DATA
 
 
-async def test_flow_user_invalid_auth(hass: HomeAssistant) -> None:
+async def test_flow_user_invalid_auth(hass: HomeAssistant, invalid_auth) -> None:
     """Test invalid authentication."""
-    with _patch_client() as client:
-        client.side_effect = exceptions.ArrAuthenticationException
-        result = await hass.config_entries.flow.async_init(
-            DOMAIN,
-            context={CONF_SOURCE: SOURCE_USER},
-        )
-        result = await hass.config_entries.flow.async_configure(
-            result["flow_id"],
-            user_input=CONF_DATA,
-        )
+    result = await hass.config_entries.flow.async_init(
+        DOMAIN,
+        context={CONF_SOURCE: SOURCE_USER},
+        data=CONF_DATA,
+    )
     assert result["type"] == data_entry_flow.RESULT_TYPE_FORM
     assert result["step_id"] == "user"
     assert result["errors"]["base"] == "invalid_auth"
 
 
-async def test_flow_user_cannot_connect(hass: HomeAssistant) -> None:
+async def test_flow_user_cannot_connect(hass: HomeAssistant, cannot_connect) -> None:
     """Test connection error."""
-    with _patch_client() as client:
-        client.side_effect = exceptions.ArrConnectionException
-        result = await hass.config_entries.flow.async_init(
-            DOMAIN,
-            context={CONF_SOURCE: SOURCE_USER},
-        )
-        result = await hass.config_entries.flow.async_configure(
-            result["flow_id"],
-            user_input=CONF_DATA,
-        )
+    result = await hass.config_entries.flow.async_init(
+        DOMAIN,
+        context={CONF_SOURCE: SOURCE_USER},
+        data=CONF_DATA,
+    )
+
     assert result["type"] == data_entry_flow.RESULT_TYPE_FORM
     assert result["step_id"] == "user"
     assert result["errors"]["base"] == "cannot_connect"
 
 
-async def test_wrong_app(hass: HomeAssistant) -> None:
+async def test_wrong_app(hass: HomeAssistant, wrong_app) -> None:
     """Test we show user form on wrong app."""
-    with patch(
-        "homeassistant.components.lidarr.config_flow.LidarrClient.async_try_zeroconf",
-        side_effect=exceptions.ArrWrongAppException,
-    ):
-        result = await hass.config_entries.flow.async_init(
-            DOMAIN,
-            context={CONF_SOURCE: SOURCE_USER},
-            data=MOCK_USER_INPUT,
-        )
+    result = await hass.config_entries.flow.async_init(
+        DOMAIN,
+        context={CONF_SOURCE: SOURCE_USER},
+        data=MOCK_INPUT,
+    )
 
     assert result["type"] == data_entry_flow.RESULT_TYPE_FORM
     assert result["step_id"] == "user"
     assert result["errors"]["base"] == "wrong_app"
 
 
-async def test_zero_conf_failure(hass: HomeAssistant) -> None:
-    """Test we show user form on api key retrieval failure."""
-    with patch(
-        "homeassistant.components.lidarr.config_flow.LidarrClient.async_try_zeroconf",
-        side_effect=exceptions.ArrZeroConfException,
-    ):
-        result = await hass.config_entries.flow.async_init(
-            DOMAIN,
-            context={CONF_SOURCE: SOURCE_USER},
-            data=MOCK_USER_INPUT,
-        )
+async def test_zeroconf_failed(hass: HomeAssistant, zeroconf_failed) -> None:
+    """Test we show user form on zeroconf failure."""
+    result = await hass.config_entries.flow.async_init(
+        DOMAIN,
+        context={CONF_SOURCE: SOURCE_USER},
+        data=MOCK_INPUT,
+    )
 
     assert result["type"] == data_entry_flow.RESULT_TYPE_FORM
     assert result["step_id"] == "user"
     assert result["errors"]["base"] == "zeroconf_failed"
 
 
-async def test_flow_user_unknown_error(hass: HomeAssistant) -> None:
+async def test_flow_user_unknown_error(hass: HomeAssistant, unknown) -> None:
     """Test unknown error."""
-    with _patch_client() as client:
-        client.side_effect = exceptions.ArrException
-        result = await hass.config_entries.flow.async_init(
-            DOMAIN,
-            context={CONF_SOURCE: SOURCE_USER},
-        )
-        result = await hass.config_entries.flow.async_configure(
-            result["flow_id"],
-            user_input=CONF_DATA,
-        )
+    result = await hass.config_entries.flow.async_init(
+        DOMAIN,
+        context={CONF_SOURCE: SOURCE_USER},
+    )
+    result = await hass.config_entries.flow.async_configure(
+        result["flow_id"],
+        user_input=CONF_DATA,
+    )
     assert result["type"] == data_entry_flow.RESULT_TYPE_FORM
     assert result["step_id"] == "user"
     assert result["errors"]["base"] == "unknown"
 
 
 async def test_flow_reauth(
-    hass: HomeAssistant, aioclient_mock: AiohttpClientMocker
+    hass: HomeAssistant, setup_integration: ComponentSetup, connection
 ) -> None:
     """Test reauth."""
-    entry = create_entry(hass)
-    mock_connection(aioclient_mock)
+    await setup_integration()
+    entry = hass.config_entries.async_entries(DOMAIN)[0]
     result = await hass.config_entries.flow.async_init(
         DOMAIN,
         context={