evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve reolink generic typing (#88786)

Browse source 
Co-authored-by: starkillerOG <starkiller.og@gmail.com>
This commit is contained in:
Marc Mueller 2023-03-06 21:54:34 +01:00 • committed by GitHub
parent 83fa4c6c60
commit 84034959ba
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 49 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

9
homeassistant/components/reolink/update.py
View file

@ -2,7 +2,7 @@
from __future__ import annotations
import logging
from typing import Any
from typing import Any, Literal
from reolink_aio.exceptions import ReolinkError
@ -34,7 +34,9 @@ async def async_setup_entry(
async_add_entities([ReolinkUpdateEntity(reolink_data)])
class ReolinkUpdateEntity(ReolinkBaseCoordinatorEntity, UpdateEntity):
class ReolinkUpdateEntity(
ReolinkBaseCoordinatorEntity[str | Literal[False]], UpdateEntity
):
"""Update entity for a Netgear device."""
_attr_device_class = UpdateDeviceClass.FIRMWARE
@ -59,9 +61,6 @@ class ReolinkUpdateEntity(ReolinkBaseCoordinatorEntity, UpdateEntity):
@property
def latest_version(self) -> str | None:
"""Latest version available for install."""
if self.coordinator.data is None:
return None
if not self.coordinator.data:
return self.installed_version