Discover new device at runtime in Plugwise (#117688)

Co-authored-by: Franck Nijhof <frenck@frenck.nl>

tests/components/plugwise/test_init.py

@@ -1,6 +1,7 @@
 """Tests for the Plugwise Climate integration."""
 
-from unittest.mock import MagicMock
+from datetime import timedelta
+from unittest.mock import MagicMock, patch
 
 from plugwise.exceptions import (
     ConnectionFailedError,
@@ -15,15 +16,45 @@ from homeassistant.components.plugwise.const import DOMAIN
 from homeassistant.config_entries import ConfigEntryState
 from homeassistant.const import Platform
 from homeassistant.core import HomeAssistant
-from homeassistant.helpers import entity_registry as er
+from homeassistant.helpers import device_registry as dr, entity_registry as er
+from homeassistant.setup import async_setup_component
+from homeassistant.util import dt as dt_util
 
-from tests.common import MockConfigEntry
+from tests.common import MockConfigEntry, async_fire_time_changed
 
+HA_PLUGWISE_SMILE_ASYNC_UPDATE = (
+    "homeassistant.components.plugwise.coordinator.Smile.async_update"
+)
 HEATER_ID = "1cbf783bb11e4a7c8a6843dee3a86927"  # Opentherm device_id for migration
 PLUG_ID = "cd0ddb54ef694e11ac18ed1cbce5dbbd"  # VCR device_id for migration
 SECONDARY_ID = (
     "1cbf783bb11e4a7c8a6843dee3a86927"  # Heater_central device_id for migration
 )
+TOM = {
+    "01234567890abcdefghijklmnopqrstu": {
+        "available": True,
+        "dev_class": "thermo_sensor",
+        "firmware": "2020-11-04T01:00:00+01:00",
+        "hardware": "1",
+        "location": "f871b8c4d63549319221e294e4f88074",
+        "model": "Tom/Floor",
+        "name": "Tom Badkamer",
+        "sensors": {
+            "battery": 99,
+            "temperature": 18.6,
+            "temperature_difference": 2.3,
+            "valve_position": 0.0,
+        },
+        "temperature_offset": {
+            "lower_bound": -2.0,
+            "resolution": 0.1,
+            "setpoint": 0.1,
+            "upper_bound": 2.0,
+        },
+        "vendor": "Plugwise",
+        "zigbee_mac_address": "ABCD012345670A01",
+    },
+}
 
 
 async def test_load_unload_config_entry(
@@ -165,3 +196,63 @@ async def test_migrate_unique_id_relay(
     entity_migrated = entity_registry.async_get(entity.entity_id)
     assert entity_migrated
     assert entity_migrated.unique_id == new_unique_id
+
+
+async def test_update_device(
+    hass: HomeAssistant,
+    mock_config_entry: MockConfigEntry,
+    mock_smile_adam_2: MagicMock,
+    device_registry: dr.DeviceRegistry,
+    entity_registry: er.EntityRegistry,
+) -> None:
+    """Test a clean-up of the device_registry."""
+    utcnow = dt_util.utcnow()
+    data = mock_smile_adam_2.async_update.return_value
+
+    mock_config_entry.add_to_hass(hass)
+    assert await async_setup_component(hass, DOMAIN, {})
+    await hass.async_block_till_done()
+
+    assert (
+        len(
+            er.async_entries_for_config_entry(
+                entity_registry, mock_config_entry.entry_id
+            )
+        )
+        == 28
+    )
+    assert (
+        len(
+            dr.async_entries_for_config_entry(
+                device_registry, mock_config_entry.entry_id
+            )
+        )
+        == 6
+    )
+
+    # Add a 2nd Tom/Floor
+    data.devices.update(TOM)
+    with patch(HA_PLUGWISE_SMILE_ASYNC_UPDATE, return_value=data):
+        async_fire_time_changed(hass, utcnow + timedelta(minutes=1))
+        await hass.async_block_till_done()
+
+        assert (
+            len(
+                er.async_entries_for_config_entry(
+                    entity_registry, mock_config_entry.entry_id
+                )
+            )
+            == 33
+        )
+        assert (
+            len(
+                dr.async_entries_for_config_entry(
+                    device_registry, mock_config_entry.entry_id
+                )
+            )
+            == 7
+        )
+        item_list: list[str] = []
+        for device_entry in list(device_registry.devices.values()):
+            item_list.extend(x[1] for x in device_entry.identifiers)
+        assert "01234567890abcdefghijklmnopqrstu" in item_list