evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve enabling of Google local fulfillment (#109192)

Browse source 
* Improve enabling of Google local fulfillment

* Add test

* Improve test coverage
This commit is contained in:
Erik Montnemery 2024-01-31 16:28:27 +01:00 • committed by GitHub
parent 6fc5804818
commit 816c2e9500
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 131 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

17
homeassistant/components/google_assistant/helpers.py
View file

@ -316,6 +316,7 @@ class AbstractConfig(ABC):
@callback
def async_enable_local_sdk(self) -> None:
"""Enable the local SDK."""
_LOGGER.debug("async_enable_local_sdk")
setup_successful = True
setup_webhook_ids = []
@ -324,11 +325,16 @@ class AbstractConfig(ABC):
self._local_sdk_active = False
return
for user_agent_id, _ in self._store.agent_user_ids.items():
for user_agent_id in self._store.agent_user_ids:
if (webhook_id := self.get_local_webhook_id(user_agent_id)) is None:
setup_successful = False
break
_LOGGER.debug(
"Register webhook handler %s for agent user id %s",
webhook_id,
user_agent_id,
)
try:
webhook.async_register(
self.hass,
@ -360,13 +366,18 @@ class AbstractConfig(ABC):
@callback
def async_disable_local_sdk(self) -> None:
"""Disable the local SDK."""
_LOGGER.debug("async_disable_local_sdk")
if not self._local_sdk_active:
return
for agent_user_id in self._store.agent_user_ids:
webhook.async_unregister(
self.hass, self.get_local_webhook_id(agent_user_id)
webhook_id = self.get_local_webhook_id(agent_user_id)
_LOGGER.debug(
"Unregister webhook handler %s for agent user id %s",
webhook_id,
agent_user_id,
)
webhook.async_unregister(self.hass, webhook_id)
self._local_sdk_active = False