evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactor and simplify homekit_controller entity setup (#32927)

Browse source
This commit is contained in:
Jc2k 2020-03-18 15:12:55 +00:00 • committed by GitHub
parent e0769f9ad4
commit 7c79adad8f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 131 additions and 160 deletions
Download patch file Download diff file Expand all files Collapse all files

27
homeassistant/components/homekit_controller/fan.py
View file

@ -44,11 +44,6 @@ class BaseHomeKitFan(HomeKitEntity, FanEntity):
# that controls whether the fan is on or off.
on_characteristic = None
def __init__(self, *args):
"""Initialise the fan."""
self._features = 0
super().__init__(*args)
def get_characteristic_types(self):
"""Define the homekit characteristics the entity cares about."""
return [
@ -58,15 +53,6 @@ class BaseHomeKitFan(HomeKitEntity, FanEntity):
self.on_characteristic,
]
def _setup_rotation_direction(self, char):
self._features |= SUPPORT_DIRECTION
def _setup_rotation_speed(self, char):
self._features |= SUPPORT_SET_SPEED
def _setup_swing_mode(self, char):
self._features |= SUPPORT_OSCILLATE
@property
def is_on(self):
"""Return true if device is on."""
@ -113,7 +99,18 @@ class BaseHomeKitFan(HomeKitEntity, FanEntity):
@property
def supported_features(self):
"""Flag supported features."""
return self._features
features = 0
if self.service.has(CharacteristicsTypes.ROTATION_DIRECTION):
features |= SUPPORT_DIRECTION
if self.service.has(CharacteristicsTypes.ROTATION_SPEED):
features |= SUPPORT_SET_SPEED
if self.service.has(CharacteristicsTypes.SWING_MODE):
features |= SUPPORT_OSCILLATE
return features
async def async_set_direction(self, direction):
"""Set the direction of the fan."""