From 7ab15c0e79fecdfaa0f29f6691b45429a6a04cdc Mon Sep 17 00:00:00 2001 From: Erik Eriksson Date: Tue, 28 Nov 2017 15:32:36 +0100 Subject: [PATCH] Tellduslive: Use magic constants for battery level. Also, the previous formula for battery level was wrong. (#10788) --- homeassistant/components/tellduslive.py | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/homeassistant/components/tellduslive.py b/homeassistant/components/tellduslive.py index fa8916aca11..ba7c1afd286 100644 --- a/homeassistant/components/tellduslive.py +++ b/homeassistant/components/tellduslive.py @@ -343,8 +343,17 @@ class TelldusLiveEntity(Entity): @property def _battery_level(self): """Return the battery level of a device.""" - return round(self.device.battery * 100 / 255) \ - if self.device.battery else None + from tellduslive import (BATTERY_LOW, + BATTERY_UNKNOWN, + BATTERY_OK) + if self.device.battery == BATTERY_LOW: + return 1 + elif self.device.battery == BATTERY_UNKNOWN: + return None + elif self.device.battery == BATTERY_OK: + return 100 + else: + return self.device.battery # Percentage @property def _last_updated(self):