evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add guard for invalid EntityCategory value (#66316)

Browse source
This commit is contained in:
Joakim Sørensen 2022-02-11 14:57:45 +01:00 • committed by GitHub
parent 1c087f5c70
commit 7a40ae13a4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
homeassistant/helpers/entity.py
View file

@ -223,7 +223,10 @@ def convert_to_entity_category(
"EntityCategory instead" % (type(value).__name__, value), "EntityCategory instead" % (type(value).__name__, value),
error_if_core=False, error_if_core=False,
) )
try:
return EntityCategory(value) return EntityCategory(value)
except ValueError:
return None
return value return value

12
tests/helpers/test_entity_registry.py
View file

@ -1138,3 +1138,15 @@ async def test_deprecated_entity_category_str(hass, registry, caplog):
assert entry.entity_category is EntityCategory.DIAGNOSTIC assert entry.entity_category is EntityCategory.DIAGNOSTIC
assert " should be updated to use EntityCategory" in caplog.text assert " should be updated to use EntityCategory" in caplog.text
async def test_invalid_entity_category_str(hass, registry, caplog):
"""Test use of invalid entity category."""
entry = er.RegistryEntry(
"light",
"hue",
"5678",
entity_category="invalid",
)
assert entry.entity_category is None