Don't reload integration for AuthError in Honeywell (#91228)

This commit is contained in:
mkmer 2023-04-17 08:55:52 -04:00 committed by GitHub
parent 3364f0fce2
commit 799080eb00
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 16 deletions

View file

@ -419,11 +419,6 @@ class HoneywellUSThermostat(ClimateEntity):
try:
await self._data.client.login()
except aiosomecomfort.AuthError:
self._attr_available = False
await self.hass.async_create_task(
self.hass.config_entries.async_reload(self._data.entry_id)
)
except (
aiosomecomfort.SomeComfortError,
ClientConnectionError,

View file

@ -1,7 +1,8 @@
"""Test the Whirlpool Sixth Sense climate domain."""
import datetime
from unittest.mock import MagicMock, patch
from unittest.mock import MagicMock
from aiohttp import ClientConnectionError
import aiosomecomfort
import pytest
from syrupy.assertion import SnapshotAssertion
@ -1020,7 +1021,6 @@ async def test_async_update_errors(
# "reload integration" test
device.refresh.side_effect = aiosomecomfort.SomeComfortError
client.login.side_effect = aiosomecomfort.AuthError
with patch("homeassistant.config_entries.ConfigEntries.async_reload") as reload:
async_fire_time_changed(
hass,
utcnow() + SCAN_INTERVAL,
@ -1030,7 +1030,17 @@ async def test_async_update_errors(
entity_id = f"climate.{device.name}"
state = hass.states.get(entity_id)
assert state.state == "unavailable"
assert reload.called_once()
device.refresh.side_effect = ClientConnectionError
async_fire_time_changed(
hass,
utcnow() + SCAN_INTERVAL,
)
await hass.async_block_till_done()
entity_id = f"climate.{device.name}"
state = hass.states.get(entity_id)
assert state.state == "unavailable"
async def test_aux_heat_off_service_call(