evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Validate state class and unit of measurement for non-numeric sensors (#83344)

Browse source 
* Validate state class and unit of measurement for non-numeric sensors

* Remove duration

* Fix rest tests
This commit is contained in:
Franck Nijhof 2022-12-06 00:07:02 +01:00 • committed by GitHub
parent 91cdf0ecf7
commit 762eb57636
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 51 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

42
tests/components/sensor/test_init.py
View file

@ -1018,18 +1018,27 @@ async def test_invalid_enumeration_entity_without_device_class(
) in caplog.text
async def test_invalid_enumeration_with_state_class(
@pytest.mark.parametrize(
"device_class",
{
SensorDeviceClass.DATE,
SensorDeviceClass.ENUM,
SensorDeviceClass.TIMESTAMP,
},
)
async def test_non_numeric_device_class_with_state_class(
hass: HomeAssistant,
caplog: pytest.LogCaptureFixture,
enable_custom_integrations: None,
device_class: SensorDeviceClass,
):
"""Test warning on numeric entities that provide an enum."""
"""Test error on numeric entities that provide an state class."""
platform = getattr(hass.components, "test.sensor")
platform.init(empty=True)
platform.ENTITIES["0"] = platform.MockSensor(
name="Test",
native_value=42,
device_class=SensorDeviceClass.ENUM,
native_value=None,
device_class=device_class,
state_class=SensorStateClass.MEASUREMENT,
options=["option1", "option2"],
)
@ -1038,23 +1047,32 @@ async def test_invalid_enumeration_with_state_class(
await hass.async_block_till_done()
assert (
"Sensor sensor.test has an state_class and thus indicating "
"it has a numeric value; however, it has the enum device class"
"Sensor sensor.test has a state class and thus indicating it has a numeric "
f"value; however, it has the non-numeric device class: {device_class}"
) in caplog.text
async def test_invalid_enumeration_with_unit_of_measurement(
@pytest.mark.parametrize(
"device_class",
{
SensorDeviceClass.DATE,
SensorDeviceClass.ENUM,
SensorDeviceClass.TIMESTAMP,
},
)
async def test_non_numeric_device_class_with_unit_of_measurement(
hass: HomeAssistant,
caplog: pytest.LogCaptureFixture,
enable_custom_integrations: None,
device_class: SensorDeviceClass,
):
"""Test warning on numeric entities that provide an enum."""
"""Test error on numeric entities that provide an unit of measurement."""
platform = getattr(hass.components, "test.sensor")
platform.init(empty=True)
platform.ENTITIES["0"] = platform.MockSensor(
name="Test",
native_value=42,
device_class=SensorDeviceClass.ENUM,
native_value=None,
device_class=device_class,
native_unit_of_measurement=UnitOfTemperature.CELSIUS,
options=["option1", "option2"],
)
@ -1063,6 +1081,6 @@ async def test_invalid_enumeration_with_unit_of_measurement(
await hass.async_block_till_done()
assert (
"Sensor sensor.test has an unit of measurement and thus indicating "
"it has a numeric value; however, it has the enum device class"
"Sensor sensor.test has a unit of measurement and thus indicating it has "
f"a numeric value; however, it has the non-numeric device class: {device_class}"
) in caplog.text