Refactor of ADS integration and introduce ADSEntity (#22583)

* Prevent toogle to false at restart

* change to asyncio.run_coroutine_threadsafe

* refactor ADS platforms; introduce AdsEntity

* fix hound findings

* some formatting

* remove redundant def.

* fix useless super delegation

* fix inconsistent ADS data type for brightness

* fix requested changes

* fix comment

homeassistant/components/ads/binary_sensor.py

@@ -1,7 +1,5 @@
 """Support for ADS binary sensors."""
 import logging
-import asyncio
-import async_timeout
 
 import voluptuous as vol
 
@@ -10,7 +8,7 @@ from homeassistant.components.binary_sensor import (
 from homeassistant.const import CONF_DEVICE_CLASS, CONF_NAME
 import homeassistant.helpers.config_validation as cv
 
-from . import CONF_ADS_VAR, DATA_ADS
+from . import CONF_ADS_VAR, DATA_ADS, AdsEntity, STATE_KEY_STATE
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -36,70 +34,25 @@ def setup_platform(hass, config, add_entities, discovery_info=None):
     add_entities([ads_sensor])
 
 
-class AdsBinarySensor(BinarySensorDevice):
+class AdsBinarySensor(AdsEntity, BinarySensorDevice):
     """Representation of ADS binary sensors."""
 
     def __init__(self, ads_hub, name, ads_var, device_class):
         """Initialize ADS binary sensor."""
-        self._name = name
-        self._unique_id = ads_var
-        self._state = None
+        super().__init__(ads_hub, name, ads_var)
         self._device_class = device_class or 'moving'
-        self._ads_hub = ads_hub
-        self.ads_var = ads_var
-        self._event = None
 
     async def async_added_to_hass(self):
         """Register device notification."""
-        def update(name, value):
-            """Handle device notifications."""
-            _LOGGER.debug('Variable %s changed its value to %d', name, value)
-            self._state = value
-            asyncio.run_coroutine_threadsafe(async_event_set(), self.hass.loop)
-            self.schedule_update_ha_state()
-
-        async def async_event_set():
-            """Set event in async context."""
-            self._event.set()
-
-        self._event = asyncio.Event()
-
-        await self.hass.async_add_executor_job(
-            self._ads_hub.add_device_notification,
-            self.ads_var, self._ads_hub.PLCTYPE_BOOL, update)
-        try:
-            with async_timeout.timeout(10):
-                await self._event.wait()
-        except asyncio.TimeoutError:
-            _LOGGER.debug('Variable %s: Timeout during first update',
-                          self.ads_var)
+        await self.async_initialize_device(self._ads_var,
+                                           self._ads_hub.PLCTYPE_BOOL)
 
     @property
-    def name(self):
-        """Return the default name of the binary sensor."""
-        return self._name
-
-    @property
-    def unique_id(self):
-        """Return an unique identifier for this entity."""
-        return self._unique_id
+    def is_on(self):
+        """Return True if the entity is on."""
+        return self._state_dict[STATE_KEY_STATE]
 
     @property
     def device_class(self):
         """Return the device class."""
         return self._device_class
-
-    @property
-    def is_on(self):
-        """Return if the binary sensor is on."""
-        return self._state
-
-    @property
-    def should_poll(self):
-        """Return False because entity pushes its state to HA."""
-        return False
-
-    @property
-    def available(self):
-        """Return False if state has not been updated yet."""
-        return self._state is not None