Allow github requirements specs in hassfest for non-core integrations (#124925)

* allow all requirements specs

* remove unnecessary tests

* Revert "remove unnecessary tests"

This reverts commit 0a2af0318d.

* Revert "allow all requirements specs"

This reverts commit d15cd27f7b.

* be lenient only for custom integrations

* don't allow blanks as requested

---------

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

script/hassfest/requirements.py

@@ -84,18 +84,19 @@ def validate_requirements_format(integration: Integration) -> bool:
         if not version:
             continue
 
-        for part in version.split(";", 1)[0].split(","):
+        if integration.core:
-            version_part = PIP_VERSION_RANGE_SEPARATOR.match(part)
+            for part in version.split(";", 1)[0].split(","):
-            if (
+                version_part = PIP_VERSION_RANGE_SEPARATOR.match(part)
-                version_part
+                if (
-                and AwesomeVersion(version_part.group(2)).strategy
+                    version_part
-                == AwesomeVersionStrategy.UNKNOWN
+                    and AwesomeVersion(version_part.group(2)).strategy
-            ):
+                    == AwesomeVersionStrategy.UNKNOWN
-                integration.add_error(
+                ):
-                    "requirements",
+                    integration.add_error(
-                    f"Unable to parse package version ({version}) for {pkg}.",
+                        "requirements",
-                )
+                        f"Unable to parse package version ({version}) for {pkg}.",
-                continue
+                    )
+                    continue
 
     return len(integration.errors) == start_errors
 

tests/hassfest/test_requirements.py

@@ -87,3 +87,22 @@ def test_validate_requirements_format_successful(integration: Integration) -> No
     ]
     assert validate_requirements_format(integration)
     assert len(integration.errors) == 0
+
+
+def test_validate_requirements_format_github_core(integration: Integration) -> None:
+    """Test requirement that points to github fails with core component."""
+    integration.manifest["requirements"] = [
+        "git+https://github.com/user/project.git@1.2.3",
+    ]
+    assert not validate_requirements_format(integration)
+    assert len(integration.errors) == 1
+
+
+def test_validate_requirements_format_github_custom(integration: Integration) -> None:
+    """Test requirement that points to github succeeds with custom component."""
+    integration.manifest["requirements"] = [
+        "git+https://github.com/user/project.git@1.2.3",
+    ]
+    integration.path = Path("")
+    assert validate_requirements_format(integration)
+    assert len(integration.errors) == 0