evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix lingering timer in sabnzbd (#92462)

Browse source
This commit is contained in:
epenet 2023-05-04 12:19:40 +02:00 • committed by GitHub
parent 88019d70fe
commit 71b86e9f97
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 23 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
homeassistant/components/sabnzbd/__init__.py
View file

@ -237,7 +237,9 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
except SabnzbdApiException as err:
_LOGGER.error(err)
async_track_time_interval(hass, async_update_sabnzbd, UPDATE_INTERVAL)
entry.async_on_unload(
async_track_time_interval(hass, async_update_sabnzbd, UPDATE_INTERVAL)
)
await hass.config_entries.async_forward_entry_setups(entry, PLATFORMS)

14
tests/components/sabnzbd/conftest.py Normal file
View file

@ -0,0 +1,14 @@
"""Configuration for Sabnzbd tests."""
from collections.abc import Generator
from unittest.mock import AsyncMock, patch
import pytest
@pytest.fixture
def mock_setup_entry() -> Generator[AsyncMock, None, None]:
"""Override async_setup_entry."""
with patch(
"homeassistant.components.sabnzbd.async_setup_entry", return_value=True
) as mock_setup_entry:
yield mock_setup_entry

12
tests/components/sabnzbd/test_config_flow.py
View file

@ -1,7 +1,8 @@
"""Define tests for the Sabnzbd config flow."""
from unittest.mock import patch
from unittest.mock import AsyncMock, patch
from pysabnzbd import SabnzbdApiException
import pytest
from homeassistant import config_entries, data_entry_flow
from homeassistant.components.sabnzbd import DOMAIN
@ -31,8 +32,10 @@ VALID_CONFIG_OLD = {
CONF_SSL: False,
}
pytestmark = pytest.mark.usefixtures("mock_setup_entry")
async def test_create_entry(hass: HomeAssistant) -> None:
async def test_create_entry(hass: HomeAssistant, mock_setup_entry: AsyncMock) -> None:
"""Test that the user step works."""
result = await hass.config_entries.flow.async_init(
DOMAIN, context={"source": config_entries.SOURCE_USER}
@ -43,10 +46,7 @@ async def test_create_entry(hass: HomeAssistant) -> None:
with patch(
"homeassistant.components.sabnzbd.sab.SabnzbdApi.check_available",
return_value=True,
), patch(
"homeassistant.components.sabnzbd.async_setup_entry",
return_value=True,
) as mock_setup_entry:
):
result2 = await hass.config_entries.flow.async_configure(
result["flow_id"],
VALID_CONFIG,