evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve devolo Home Control code quality (#40708)

Browse source
This commit is contained in:
Guido Schmitz 2020-09-28 17:37:46 +02:00 • committed by GitHub
parent e564af0b5b
commit 70ed838571
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
homeassistant/components/devolo_home_control/binary_sensor.py
View file

@ -131,8 +131,6 @@ class DevoloRemoteControl(DevoloDeviceEntity, BinarySensorEntity):
message[0] == self._remote_control_property.element_uid and message[1] == 0
):
self._state = False
elif message[0].startswith("hdm"):
self._available = self._device_instance.is_online()
else:
_LOGGER.debug("No valid message received: %s", message)
self._generic_message(message)
self.schedule_update_ha_state()

12
homeassistant/components/devolo_home_control/devolo_device.py
View file

@ -78,11 +78,17 @@ class DevoloDeviceEntity(Entity):
return self._available
def _sync(self, message):
"""Update the binary sensor state."""
"""Update the state."""
if message[0] == self._unique_id:
self._value = message[1]
elif message[0].startswith("hdm"):
else:
self._generic_message(message)
self.schedule_update_ha_state()
def _generic_message(self, message):
"""Handle unexpected messages."""
if message[0].startswith("hdm"):
# Maybe the API wants to tell us, that the device went on- or offline.
self._available = self._device_instance.is_online()
else:
_LOGGER.debug("No valid message received: %s", message)
self.schedule_update_ha_state()

4
homeassistant/components/devolo_home_control/sensor.py
View file

@ -140,8 +140,6 @@ class DevoloConsumptionEntity(DevoloMultiLevelDeviceEntity):
self._device_instance.consumption_property[self._unique_id],
self._sensor_type,
)
elif message[0].startswith("hdm"):
self._available = self._device_instance.is_online()
else:
_LOGGER.debug("No valid message received: %s", message)
self._generic_message(message)
self.schedule_update_ha_state()

4
homeassistant/components/devolo_home_control/switch.py
View file

@ -83,8 +83,6 @@ class DevoloSwitch(DevoloDeviceEntity, SwitchEntity):
self._consumption = self._device_instance.consumption_property[
message[0]
].current
elif message[0].startswith("hdm"):
self._available = self._device_instance.is_online()
else:
_LOGGER.debug("No valid message received: %s", message)
self._generic_message(message)
self.schedule_update_ha_state()