evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add action attribute to generic hygrostat (#95675)

Browse source 
* add action attribute to generic hygrostat

* Simplified initialization
This commit is contained in:
Denis Shulyaka 2023-07-02 18:51:11 +03:00 • committed by GitHub
parent b314e2b1a1
commit 7026ea643e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
homeassistant/components/generic_hygrostat/humidifier.py
View file

@ -9,6 +9,7 @@ from homeassistant.components.humidifier import (
MODE_AWAY, MODE_AWAY,
MODE_NORMAL, MODE_NORMAL,
PLATFORM_SCHEMA, PLATFORM_SCHEMA,
HumidifierAction,
HumidifierDeviceClass, HumidifierDeviceClass,
HumidifierEntity, HumidifierEntity,
HumidifierEntityFeature, HumidifierEntityFeature,
@ -158,6 +159,7 @@ class GenericHygrostat(HumidifierEntity, RestoreEntity):
self._is_away = False self._is_away = False
if not self._device_class: if not self._device_class:
self._device_class = HumidifierDeviceClass.HUMIDIFIER self._device_class = HumidifierDeviceClass.HUMIDIFIER
self._attr_action = HumidifierAction.IDLE
async def async_added_to_hass(self): async def async_added_to_hass(self):
"""Run when entity about to be added.""" """Run when entity about to be added."""
@ -361,6 +363,15 @@ class GenericHygrostat(HumidifierEntity, RestoreEntity):
"""Handle humidifier switch state changes.""" """Handle humidifier switch state changes."""
if new_state is None: if new_state is None:
return return
if new_state.state == STATE_ON:
if self._device_class == HumidifierDeviceClass.DEHUMIDIFIER:
self._attr_action = HumidifierAction.DRYING
else:
self._attr_action = HumidifierAction.HUMIDIFYING
else:
self._attr_action = HumidifierAction.IDLE
self.async_schedule_update_ha_state() self.async_schedule_update_ha_state()
async def _async_update_humidity(self, humidity): async def _async_update_humidity(self, humidity):

7
tests/components/generic_hygrostat/test_humidifier.py
View file

@ -121,6 +121,7 @@ async def test_humidifier_input_boolean(hass: HomeAssistant, setup_comp_1) -> No
await hass.async_block_till_done() await hass.async_block_till_done()
assert hass.states.get(humidifier_switch).state == STATE_ON assert hass.states.get(humidifier_switch).state == STATE_ON
assert hass.states.get(ENTITY).attributes.get("action") == "humidifying"
async def test_humidifier_switch( async def test_humidifier_switch(
@ -165,6 +166,7 @@ async def test_humidifier_switch(
await hass.async_block_till_done() await hass.async_block_till_done()
assert hass.states.get(humidifier_switch).state == STATE_ON assert hass.states.get(humidifier_switch).state == STATE_ON
assert hass.states.get(ENTITY).attributes.get("action") == "humidifying"
def _setup_sensor(hass, humidity): def _setup_sensor(hass, humidity):
@ -277,6 +279,7 @@ async def test_default_setup_params(hass: HomeAssistant, setup_comp_2) -> None:
assert state.attributes.get("min_humidity") == 0 assert state.attributes.get("min_humidity") == 0
assert state.attributes.get("max_humidity") == 100 assert state.attributes.get("max_humidity") == 100
assert state.attributes.get("humidity") == 0 assert state.attributes.get("humidity") == 0
assert state.attributes.get("action") == "idle"
async def test_default_setup_params_dehumidifier( async def test_default_setup_params_dehumidifier(
@ -287,6 +290,7 @@ async def test_default_setup_params_dehumidifier(
assert state.attributes.get("min_humidity") == 0 assert state.attributes.get("min_humidity") == 0
assert state.attributes.get("max_humidity") == 100 assert state.attributes.get("max_humidity") == 100
assert state.attributes.get("humidity") == 100 assert state.attributes.get("humidity") == 100
assert state.attributes.get("action") == "idle"
async def test_get_modes(hass: HomeAssistant, setup_comp_2) -> None: async def test_get_modes(hass: HomeAssistant, setup_comp_2) -> None:
@ -648,6 +652,7 @@ async def test_set_target_humidity_dry_off(hass: HomeAssistant, setup_comp_3) ->
assert call.domain == HASS_DOMAIN assert call.domain == HASS_DOMAIN
assert call.service == SERVICE_TURN_OFF assert call.service == SERVICE_TURN_OFF
assert call.data["entity_id"] == ENT_SWITCH assert call.data["entity_id"] == ENT_SWITCH
assert hass.states.get(ENTITY).attributes.get("action") == "drying"
async def test_turn_away_mode_on_drying(hass: HomeAssistant, setup_comp_3) -> None: async def test_turn_away_mode_on_drying(hass: HomeAssistant, setup_comp_3) -> None:
@ -799,6 +804,7 @@ async def test_running_when_operating_mode_is_off_2(
assert call.domain == HASS_DOMAIN assert call.domain == HASS_DOMAIN
assert call.service == SERVICE_TURN_OFF assert call.service == SERVICE_TURN_OFF
assert call.data["entity_id"] == ENT_SWITCH assert call.data["entity_id"] == ENT_SWITCH
assert hass.states.get(ENTITY).attributes.get("action") == "off"
async def test_no_state_change_when_operation_mode_off_2( async def test_no_state_change_when_operation_mode_off_2(
@ -818,6 +824,7 @@ async def test_no_state_change_when_operation_mode_off_2(
_setup_sensor(hass, 45) _setup_sensor(hass, 45)
await hass.async_block_till_done() await hass.async_block_till_done()
assert len(calls) == 0 assert len(calls) == 0
assert hass.states.get(ENTITY).attributes.get("action") == "off"
@pytest.fixture @pytest.fixture