evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix DHWP overkiz_to_operation_mode creation list (#83885)

Browse source 
* Fix dhWP overkiz_to_operation_mode creation list

* Improve operation__list too and rename var

* Improve if condition

* Improve state_modefintion test

Co-authored-by: Thibaut <thibaut@etienne.pw>

Co-authored-by: Thibaut <thibaut@etienne.pw>
This commit is contained in:
Nyro 2022-12-22 13:39:05 +01:00 • committed by GitHub
parent d9c19e6e11
commit 6ee8c8b60e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
homeassistant/components/overkiz/water_heater_entities/domestic_hot_water_production.py
View file

@ -29,8 +29,6 @@ OVERKIZ_TO_OPERATION_MODE: dict[str, str] = {
OverkizCommandParam.BOOST: STATE_PERFORMANCE,
}
OPERATION_MODE_TO_OVERKIZ = {v: k for k, v in OVERKIZ_TO_OPERATION_MODE.items()}
DHWP_AWAY_MODES = [
OverkizCommandParam.ABSENCE,
OverkizCommandParam.AWAY,
@ -49,7 +47,6 @@ class DomesticHotWaterProduction(OverkizEntity, WaterHeaterEntity):
WaterHeaterEntityFeature.TARGET_TEMPERATURE
| WaterHeaterEntityFeature.OPERATION_MODE
)
_attr_operation_list = [*OPERATION_MODE_TO_OVERKIZ]
def __init__(
self, device_url: str, coordinator: OverkizDataUpdateCoordinator
@ -58,17 +55,21 @@ class DomesticHotWaterProduction(OverkizEntity, WaterHeaterEntity):
super().__init__(device_url, coordinator)
# Init operation mode to set for this specific device
self.overkiz_to_operation_mode: dict[str, str] = {}
self.operation_mode_to_overkiz: dict[str, str] = {}
self._attr_operation_list = []
state_mode_definition = self.executor.select_definition_state(
OverkizState.IO_DHW_MODE, OverkizState.MODBUSLINK_DHW_MODE
)
if state_mode_definition and state_mode_definition.values:
for param, mode in OVERKIZ_TO_OPERATION_MODE.items():
# Filter only for mode allowed by this device
for param, mode in OVERKIZ_TO_OPERATION_MODE.items():
if param in state_mode_definition.values:
self.overkiz_to_operation_mode[param] = mode
else:
self.overkiz_to_operation_mode = OVERKIZ_TO_OPERATION_MODE
# or allow all if no mode definition found
if (
not state_mode_definition
or state_mode_definition.values
and param in state_mode_definition.values
):
self.operation_mode_to_overkiz[mode] = param
self._attr_operation_list.append(param)
@property
def _is_boost_mode_on(self) -> bool:
@ -323,7 +324,7 @@ class DomesticHotWaterProduction(OverkizEntity, WaterHeaterEntity):
)
await self.executor.async_execute_command(
OverkizCommand.SET_DHW_MODE, self.overkiz_to_operation_mode[operation_mode]
OverkizCommand.SET_DHW_MODE, self.operation_mode_to_overkiz[operation_mode]
)
if self.executor.has_command(OverkizCommand.REFRESH_BOOST_MODE_DURATION):