From 6b9fb4bda34e28770efa51d7431d17d8cfa964cc Mon Sep 17 00:00:00 2001
From: Brent Petit <bjpetit@users.noreply.github.com>
Date: Tue, 26 Oct 2021 06:37:43 -0500
Subject: [PATCH] Clean up rounding in Ecobee integration (#56319)

---
 homeassistant/components/ecobee/climate.py | 24 ++++++++++++++--------
 tests/components/ecobee/test_climate.py    |  4 ++--
 2 files changed, 17 insertions(+), 11 deletions(-)

diff --git a/homeassistant/components/ecobee/climate.py b/homeassistant/components/ecobee/climate.py
index bc5f74c5022..473ba0cdd58 100644
--- a/homeassistant/components/ecobee/climate.py
+++ b/homeassistant/components/ecobee/climate.py
@@ -32,6 +32,7 @@ from homeassistant.components.climate.const import (
 from homeassistant.const import (
     ATTR_ENTITY_ID,
     ATTR_TEMPERATURE,
+    PRECISION_HALVES,
     PRECISION_TENTHS,
     STATE_ON,
     TEMP_FAHRENHEIT,
@@ -394,24 +395,29 @@ class Thermostat(ClimateEntity):
         return PRECISION_TENTHS
 
     @property
-    def current_temperature(self):
+    def current_temperature(self) -> float:
         """Return the current temperature."""
         return self.thermostat["runtime"]["actualTemperature"] / 10.0
 
     @property
-    def target_temperature_low(self):
+    def target_temperature_low(self) -> float | None:
         """Return the lower bound temperature we try to reach."""
         if self.hvac_mode == HVAC_MODE_HEAT_COOL:
-            return round(self.thermostat["runtime"]["desiredHeat"] / 10.0)
+            return self.thermostat["runtime"]["desiredHeat"] / 10.0
         return None
 
     @property
-    def target_temperature_high(self):
+    def target_temperature_high(self) -> float | None:
         """Return the upper bound temperature we try to reach."""
         if self.hvac_mode == HVAC_MODE_HEAT_COOL:
-            return round(self.thermostat["runtime"]["desiredCool"] / 10.0)
+            return self.thermostat["runtime"]["desiredCool"] / 10.0
         return None
 
+    @property
+    def target_temperature_step(self) -> float:
+        """Set target temperature step to halves."""
+        return PRECISION_HALVES
+
     @property
     def has_humidifier_control(self):
         """Return true if humidifier connected to thermostat and set to manual/on mode."""
@@ -438,14 +444,14 @@ class Thermostat(ClimateEntity):
         return DEFAULT_MAX_HUMIDITY
 
     @property
-    def target_temperature(self):
+    def target_temperature(self) -> float | None:
         """Return the temperature we try to reach."""
         if self.hvac_mode == HVAC_MODE_HEAT_COOL:
             return None
         if self.hvac_mode == HVAC_MODE_HEAT:
-            return round(self.thermostat["runtime"]["desiredHeat"] / 10.0)
+            return self.thermostat["runtime"]["desiredHeat"] / 10.0
         if self.hvac_mode == HVAC_MODE_COOL:
-            return round(self.thermostat["runtime"]["desiredCool"] / 10.0)
+            return self.thermostat["runtime"]["desiredCool"] / 10.0
         return None
 
     @property
@@ -682,7 +688,7 @@ class Thermostat(ClimateEntity):
             heat_temp = temp
             cool_temp = temp
         else:
-            delta = self.thermostat["settings"]["heatCoolMinDelta"] / 10
+            delta = self.thermostat["settings"]["heatCoolMinDelta"] / 10.0
             heat_temp = temp - delta
             cool_temp = temp + delta
         self.set_auto_temp_hold(heat_temp, cool_temp)
diff --git a/tests/components/ecobee/test_climate.py b/tests/components/ecobee/test_climate.py
index 195c086adda..da4cc6cf455 100644
--- a/tests/components/ecobee/test_climate.py
+++ b/tests/components/ecobee/test_climate.py
@@ -87,14 +87,14 @@ async def test_target_temperature_low(ecobee_fixture, thermostat):
     """Test target low temperature."""
     assert thermostat.target_temperature_low == 40
     ecobee_fixture["runtime"]["desiredHeat"] = 502
-    assert thermostat.target_temperature_low == 50
+    assert thermostat.target_temperature_low == 50.2
 
 
 async def test_target_temperature_high(ecobee_fixture, thermostat):
     """Test target high temperature."""
     assert thermostat.target_temperature_high == 20
     ecobee_fixture["runtime"]["desiredCool"] = 679
-    assert thermostat.target_temperature_high == 68
+    assert thermostat.target_temperature_high == 67.9
 
 
 async def test_target_temperature(ecobee_fixture, thermostat):