evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add support for new select selector properties (#68952)

Browse source 
* Add support for new select selector properties

* fix mode option

* Apply suggestions from code review

* Correct validation for empty options, update tests

Co-authored-by: Erik Montnemery <erik@montnemery.com>
This commit is contained in:
Raman Gupta 2022-03-31 05:28:49 -04:00 • committed by GitHub
parent 9432ab07c2
commit 6b2fe6cba9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 53 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

36
tests/helpers/test_selector.py
View file

@ -246,7 +246,7 @@ def test_number_selector_schema(schema, valid_selections, invalid_selections):
),
)
def test_number_selector_schema_error(schema):
"""Test select selector."""
"""Test number selector."""
with pytest.raises(vol.Invalid):
selector.validate_selector({"number": schema})
@ -349,7 +349,7 @@ def test_text_selector_schema(schema, valid_selections, invalid_selections):
(
{"options": ["red", "green", "blue"]},
("red", "green", "blue"),
("cat", 0, None),
("cat", 0, None, ["red"]),
),
(
{
@ -359,7 +359,36 @@ def test_text_selector_schema(schema, valid_selections, invalid_selections):
]
},
("red", "green"),
("cat", 0, None),
("cat", 0, None, ["red"]),
),
(
{"options": ["red", "green", "blue"], "multiple": True},
(["red"], ["green", "blue"], []),
("cat", 0, None, "red"),
),
(
{
"options": ["red", "green", "blue"],
"multiple": True,
"custom_value": True,
},
(["red"], ["green", "blue"], ["red", "cat"], []),
("cat", 0, None, "red"),
),
(
{"options": ["red", "green", "blue"], "custom_value": True},
("red", "green", "blue", "cat"),
(0, None, ["red"]),
),
(
{"options": [], "custom_value": True},
("red", "cat"),
(0, None, ["red"]),
),
(
{"options": [], "custom_value": True, "multiple": True},
(["red"], ["green", "blue"], []),
(0, None, "red"),
),
),
)
@ -373,7 +402,6 @@ def test_select_selector_schema(schema, valid_selections, invalid_selections):
(
{}, # Must have options
{"options": {"hello": "World"}}, # Options must be a list
{"options": []}, # Must have at least option
# Options must be strings or value / label pairs
{"options": [{"hello": "World"}]},
# Options must all be of the same type