Update pylint to 2.10.1 (#54963)
* Update pylint to 2.10.0 * useless-suppression * Consider-using-tuple * Apply suggestions from code review Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io> * Use dict.items() * Add pylint disable * Use pylint 2.10.1 Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
This commit is contained in:
parent
5142ebfcc2
commit
69e413ac1e
15 changed files with 11 additions and 33 deletions
|
@ -157,7 +157,7 @@ class BraviaTVOptionsFlowHandler(config_entries.OptionsFlow):
|
|||
content_mapping = await self.hass.async_add_executor_job(
|
||||
braviarc.load_source_list
|
||||
)
|
||||
self.source_list = {item: item for item in [*content_mapping]}
|
||||
self.source_list = {item: item for item in content_mapping}
|
||||
return await self.async_step_user()
|
||||
|
||||
async def async_step_user(
|
||||
|
|
|
@ -69,8 +69,6 @@ class TurboJPEGSingleton:
|
|||
|
||||
def __init__(self) -> None:
|
||||
"""Try to create TurboJPEG only once."""
|
||||
# pylint: disable=unused-private-member
|
||||
# https://github.com/PyCQA/pylint/issues/4681
|
||||
try:
|
||||
# TurboJPEG checks for libturbojpeg
|
||||
# when its created, but it imports
|
||||
|
|
|
@ -504,7 +504,6 @@ class ClimateEntity(Entity):
|
|||
async def async_turn_on(self) -> None:
|
||||
"""Turn the entity on."""
|
||||
if hasattr(self, "turn_on"):
|
||||
# pylint: disable=no-member
|
||||
await self.hass.async_add_executor_job(self.turn_on) # type: ignore[attr-defined]
|
||||
return
|
||||
|
||||
|
@ -518,7 +517,6 @@ class ClimateEntity(Entity):
|
|||
async def async_turn_off(self) -> None:
|
||||
"""Turn the entity off."""
|
||||
if hasattr(self, "turn_off"):
|
||||
# pylint: disable=no-member
|
||||
await self.hass.async_add_executor_job(self.turn_off) # type: ignore[attr-defined]
|
||||
return
|
||||
|
||||
|
|
|
@ -184,20 +184,14 @@ def _detect_device_type_and_class(node: Group | Node) -> (str, str):
|
|||
# Z-Wave Devices:
|
||||
if node.protocol == PROTO_ZWAVE:
|
||||
device_type = f"Z{node.zwave_props.category}"
|
||||
for device_class in [*BINARY_SENSOR_DEVICE_TYPES_ZWAVE]:
|
||||
if (
|
||||
node.zwave_props.category
|
||||
in BINARY_SENSOR_DEVICE_TYPES_ZWAVE[device_class]
|
||||
):
|
||||
for device_class, values in BINARY_SENSOR_DEVICE_TYPES_ZWAVE.items():
|
||||
if node.zwave_props.category in values:
|
||||
return device_class, device_type
|
||||
return (None, device_type)
|
||||
|
||||
# Other devices (incl Insteon.)
|
||||
for device_class in [*BINARY_SENSOR_DEVICE_TYPES_ISY]:
|
||||
if any(
|
||||
device_type.startswith(t)
|
||||
for t in set(BINARY_SENSOR_DEVICE_TYPES_ISY[device_class])
|
||||
):
|
||||
for device_class, values in BINARY_SENSOR_DEVICE_TYPES_ISY.items():
|
||||
if any(device_type.startswith(t) for t in values):
|
||||
return device_class, device_type
|
||||
return (None, device_type)
|
||||
|
||||
|
|
|
@ -529,7 +529,7 @@ class Profile:
|
|||
transition: int | None = None
|
||||
hs_color: tuple[float, float] | None = dataclasses.field(init=False)
|
||||
|
||||
SCHEMA = vol.Schema( # pylint: disable=invalid-name
|
||||
SCHEMA = vol.Schema(
|
||||
vol.Any(
|
||||
vol.ExactSequence(
|
||||
(
|
||||
|
|
|
@ -813,7 +813,6 @@ class MediaPlayerEntity(Entity):
|
|||
async def async_toggle(self):
|
||||
"""Toggle the power on the media player."""
|
||||
if hasattr(self, "toggle"):
|
||||
# pylint: disable=no-member
|
||||
await self.hass.async_add_executor_job(self.toggle)
|
||||
return
|
||||
|
||||
|
@ -828,7 +827,6 @@ class MediaPlayerEntity(Entity):
|
|||
This method is a coroutine.
|
||||
"""
|
||||
if hasattr(self, "volume_up"):
|
||||
# pylint: disable=no-member
|
||||
await self.hass.async_add_executor_job(self.volume_up)
|
||||
return
|
||||
|
||||
|
@ -841,7 +839,6 @@ class MediaPlayerEntity(Entity):
|
|||
This method is a coroutine.
|
||||
"""
|
||||
if hasattr(self, "volume_down"):
|
||||
# pylint: disable=no-member
|
||||
await self.hass.async_add_executor_job(self.volume_down)
|
||||
return
|
||||
|
||||
|
@ -851,7 +848,6 @@ class MediaPlayerEntity(Entity):
|
|||
async def async_media_play_pause(self):
|
||||
"""Play or pause the media player."""
|
||||
if hasattr(self, "media_play_pause"):
|
||||
# pylint: disable=no-member
|
||||
await self.hass.async_add_executor_job(self.media_play_pause)
|
||||
return
|
||||
|
||||
|
|
|
@ -201,7 +201,7 @@ class NFAndroidTVNotificationService(BaseNotificationService):
|
|||
if local_path is not None:
|
||||
# Check whether path is whitelisted in configuration.yaml
|
||||
if self.is_allowed_path(local_path):
|
||||
return open(local_path, "rb") # pylint: disable=consider-using-with
|
||||
return open(local_path, "rb")
|
||||
_LOGGER.warning("'%s' is not secure to load data from!", local_path)
|
||||
else:
|
||||
_LOGGER.warning("Neither URL nor local path found in params!")
|
||||
|
|
|
@ -183,7 +183,6 @@ class BaseNotificationService:
|
|||
if hasattr(self, "targets"):
|
||||
stale_targets = set(self.registered_targets)
|
||||
|
||||
# pylint: disable=no-member
|
||||
for name, target in self.targets.items(): # type: ignore
|
||||
target_name = slugify(f"{self._target_service_name_prefix}_{name}")
|
||||
if target_name in stale_targets:
|
||||
|
|
|
@ -68,7 +68,7 @@ async def async_setup(hass: HomeAssistant, config: ConfigType) -> bool:
|
|||
@callback
|
||||
def _async_setup_shared_data(hass: HomeAssistant):
|
||||
"""Create shared data for platform config and rest coordinators."""
|
||||
hass.data[DOMAIN] = {key: [] for key in [REST_DATA, *COORDINATOR_AWARE_PLATFORMS]}
|
||||
hass.data[DOMAIN] = {key: [] for key in (REST_DATA, *COORDINATOR_AWARE_PLATFORMS)}
|
||||
|
||||
|
||||
async def _async_process_config(hass, config) -> bool:
|
||||
|
|
|
@ -104,7 +104,7 @@ async def discover_devices(hass, hass_config):
|
|||
async with async_timeout.timeout(SCAN_INTERVAL.total_seconds()):
|
||||
channels = {
|
||||
channel["id"]: channel
|
||||
for channel in await server.get_channels(
|
||||
for channel in await server.get_channels( # pylint: disable=cell-var-from-loop
|
||||
include=["iodevice", "state", "connected"]
|
||||
)
|
||||
}
|
||||
|
|
|
@ -111,8 +111,6 @@ async def async_setup(hass: HomeAssistant, config: ConfigType) -> bool:
|
|||
vol.Lower,
|
||||
vol.In(
|
||||
[
|
||||
# https://github.com/PyCQA/pylint/issues/2062
|
||||
# pylint: disable=no-member
|
||||
LockState.UNLOCKED.name.lower(),
|
||||
LockState.LOCKED_IN.name.lower(),
|
||||
LockState.LOCKED_OUT.name.lower(),
|
||||
|
@ -156,8 +154,6 @@ class SurePetcareAPI:
|
|||
async def set_lock_state(self, flap_id: int, state: str) -> None:
|
||||
"""Update the lock state of a flap."""
|
||||
|
||||
# https://github.com/PyCQA/pylint/issues/2062
|
||||
# pylint: disable=no-member
|
||||
if state == LockState.UNLOCKED.name.lower():
|
||||
await self.surepy.sac.unlock(flap_id)
|
||||
elif state == LockState.LOCKED_IN.name.lower():
|
||||
|
|
|
@ -286,7 +286,7 @@ def load_data(
|
|||
_LOGGER.warning("Can't load data in %s after %s retries", url, retry_num)
|
||||
elif filepath is not None:
|
||||
if hass.config.is_allowed_path(filepath):
|
||||
return open(filepath, "rb") # pylint: disable=consider-using-with
|
||||
return open(filepath, "rb")
|
||||
|
||||
_LOGGER.warning("'%s' are not secure to load data from!", filepath)
|
||||
else:
|
||||
|
|
|
@ -40,7 +40,6 @@ CONFIG_SCHEMA = vol.Schema(
|
|||
extra=vol.ALLOW_EXTRA,
|
||||
)
|
||||
|
||||
# pylint: disable=no-member
|
||||
PROFILE_TO_STR_SETTABLE = {
|
||||
VALLOX_PROFILE.HOME: "Home",
|
||||
VALLOX_PROFILE.AWAY: "Away",
|
||||
|
@ -50,7 +49,6 @@ PROFILE_TO_STR_SETTABLE = {
|
|||
|
||||
STR_TO_PROFILE = {v: k for (k, v) in PROFILE_TO_STR_SETTABLE.items()}
|
||||
|
||||
# pylint: disable=no-member
|
||||
PROFILE_TO_STR_REPORTABLE = {
|
||||
**{VALLOX_PROFILE.NONE: "None", VALLOX_PROFILE.EXTRA: "Extra"},
|
||||
**PROFILE_TO_STR_SETTABLE,
|
||||
|
|
|
@ -622,7 +622,6 @@ class Entity(ABC):
|
|||
await self.parallel_updates.acquire()
|
||||
|
||||
try:
|
||||
# pylint: disable=no-member
|
||||
if hasattr(self, "async_update"):
|
||||
task = self.hass.async_create_task(self.async_update()) # type: ignore
|
||||
elif hasattr(self, "update"):
|
||||
|
|
|
@ -13,7 +13,7 @@ jsonpickle==1.4.1
|
|||
mock-open==1.4.0
|
||||
mypy==0.910
|
||||
pre-commit==2.14.0
|
||||
pylint==2.9.5
|
||||
pylint==2.10.1
|
||||
pipdeptree==1.0.0
|
||||
pylint-strict-informational==0.1
|
||||
pytest-aiohttp==0.3.0
|
||||
|
|
Loading…
Add table
Reference in a new issue