evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Rename homekit "Filter Life" sensor to "Filter lifetime" (#96821)

Browse source 
* String review: rename 'life' to 'lifetime'

- The term life, such as in 'filter life' can be ambiguous.
- Renamed to 'lifetime', as quite a few integrations use the term 'lifetime' to express this concept
- Improves consistency and should be easier to understand.

* HomeKit: adapt test case to reflect string change

* Fix test case failure caused by string rename: first step
This commit is contained in:
c0ffeeca7 2023-07-18 15:11:14 +02:00 • committed by GitHub
parent 0bdfb95d1d
commit 67eeed6703
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
homeassistant/components/homekit_controller/sensor.py
View file

@ -333,7 +333,7 @@ SIMPLE_SENSOR: dict[str, HomeKitSensorEntityDescription] = {
), ),
CharacteristicsTypes.FILTER_LIFE_LEVEL: HomeKitSensorEntityDescription( CharacteristicsTypes.FILTER_LIFE_LEVEL: HomeKitSensorEntityDescription(
key=CharacteristicsTypes.FILTER_LIFE_LEVEL, key=CharacteristicsTypes.FILTER_LIFE_LEVEL,
name="Filter Life", name="Filter lifetime",
state_class=SensorStateClass.MEASUREMENT, state_class=SensorStateClass.MEASUREMENT,
native_unit_of_measurement=PERCENTAGE, native_unit_of_measurement=PERCENTAGE,
), ),

4
tests/components/homekit_controller/specific_devices/test_airversa_ap2.py
View file

@ -60,8 +60,8 @@ async def test_airversa_ap2_setup(hass: HomeAssistant) -> None:
capabilities={"state_class": SensorStateClass.MEASUREMENT}, capabilities={"state_class": SensorStateClass.MEASUREMENT},
), ),
EntityTestInfo( EntityTestInfo(
entity_id="sensor.airversa_ap2_1808_filter_life", entity_id="sensor.airversa_ap2_1808_filter_lifetime",
friendly_name="Airversa AP2 1808 Filter Life", friendly_name="Airversa AP2 1808 Filter lifetime",
unique_id="00:00:00:00:00:00_1_32896_32900", unique_id="00:00:00:00:00:00_1_32896_32900",
state="100.0", state="100.0",
capabilities={"state_class": SensorStateClass.MEASUREMENT}, capabilities={"state_class": SensorStateClass.MEASUREMENT},