evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Raise on smtp notification if attachment is not allowed (#104981)

Browse source 
* Raise smtp notification if attachment not allowed

* Pass url as placeholder

* Use variable in err message

* Add allow_list as placeholder
This commit is contained in:
Jan Bouwhuis 2023-12-04 11:48:29 +01:00 • committed by Franck Nijhof
parent 204cc20bc2
commit 64f7855b94
No known key found for this signature in database
GPG key ID: D62583BA8AB11CA3
3 changed files with 38 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

17
tests/components/smtp/test_notify.py
View file

@ -11,6 +11,7 @@ from homeassistant.components.smtp.const import DOMAIN
from homeassistant.components.smtp.notify import MailNotificationService
from homeassistant.const import SERVICE_RELOAD
from homeassistant.core import HomeAssistant
from homeassistant.exceptions import ServiceValidationError
from homeassistant.setup import async_setup_component
from tests.common import get_fixture_path
@ -111,7 +112,7 @@ EMAIL_DATA = [
),
(
"Test msg",
{"html": HTML, "images": ["test.jpg"]},
{"html": HTML, "images": ["tests/testing_config/notify/test_not_exists.jpg"]},
"Content-Type: multipart/related",
),
(
@ -156,7 +157,6 @@ def test_send_message(
)
def test_sending_insecure_files_fails(
hass: HomeAssistant,
caplog: pytest.LogCaptureFixture,
message_data,
data,
content_type,
@ -165,10 +165,19 @@ def test_sending_insecure_files_fails(
"""Verify if we cannot send messages with insecure attachments."""
sample_email = "<mock@mock>"
message.hass = hass
with patch("email.utils.make_msgid", return_value=sample_email):
with patch("email.utils.make_msgid", return_value=sample_email), pytest.raises(
ServiceValidationError
) as exc:
result, _ = message.send_message(message_data, data=data)
assert content_type in result
assert "test.jpg' is not secure to load data from, ignoring attachment"
assert exc.value.translation_key == "remote_path_not_allowed"
assert exc.value.translation_domain == DOMAIN
assert (
str(exc.value.translation_placeholders["file_path"])
== "tests/testing_config/notify"
)
assert exc.value.translation_placeholders["url"]
assert exc.value.translation_placeholders["file_name"] == "test.jpg"
def test_send_text_message(hass: HomeAssistant, message) -> None: