evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Code cleanup for transmission integration (#103078)

Browse source
This commit is contained in:
Rami Mosleh 2023-10-31 11:49:03 +04:00 • committed by GitHub
parent 85d49a2920
commit 61a1245a84
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

12
homeassistant/components/transmission/__init__.py
View file

@ -1,7 +1,6 @@
"""Support for the Transmission BitTorrent client API.""" """Support for the Transmission BitTorrent client API."""
from __future__ import annotations from __future__ import annotations
from datetime import timedelta
from functools import partial from functools import partial
import logging import logging
import re import re
@ -22,7 +21,6 @@ from homeassistant.const import (
CONF_NAME, CONF_NAME,
CONF_PASSWORD, CONF_PASSWORD,
CONF_PORT, CONF_PORT,
CONF_SCAN_INTERVAL,
CONF_USERNAME, CONF_USERNAME,
Platform, Platform,
) )
@ -69,7 +67,7 @@ MIGRATION_NAME_TO_KEY = {
SERVICE_BASE_SCHEMA = vol.Schema( SERVICE_BASE_SCHEMA = vol.Schema(
{ {
vol.Exclusive(CONF_ENTRY_ID, "identifier"): selector.ConfigEntrySelector(), vol.Required(CONF_ENTRY_ID): selector.ConfigEntrySelector(),
} }
) )
@ -135,7 +133,6 @@ async def async_setup_entry(hass: HomeAssistant, config_entry: ConfigEntry) -> b
hass.data.setdefault(DOMAIN, {})[config_entry.entry_id] = coordinator hass.data.setdefault(DOMAIN, {})[config_entry.entry_id] = coordinator
await hass.config_entries.async_forward_entry_setups(config_entry, PLATFORMS) await hass.config_entries.async_forward_entry_setups(config_entry, PLATFORMS)
config_entry.add_update_listener(async_options_updated)
async def add_torrent(service: ServiceCall) -> None: async def add_torrent(service: ServiceCall) -> None:
"""Add new torrent to download.""" """Add new torrent to download."""
@ -244,10 +241,3 @@ async def get_api(
except TransmissionError as error: except TransmissionError as error:
_LOGGER.error(error) _LOGGER.error(error)
raise UnknownError from error raise UnknownError from error
async def async_options_updated(hass: HomeAssistant, entry: ConfigEntry) -> None:
"""Triggered by config entry options updates."""
coordinator: TransmissionDataUpdateCoordinator = hass.data[DOMAIN][entry.entry_id]
coordinator.update_interval = timedelta(seconds=entry.options[CONF_SCAN_INTERVAL])
await coordinator.async_request_refresh()

9
homeassistant/components/transmission/config_flow.py
View file

@ -55,12 +55,9 @@ class TransmissionFlowHandler(config_entries.ConfigFlow, domain=DOMAIN):
errors = {} errors = {}
if user_input is not None: if user_input is not None:
for entry in self._async_current_entries(): self._async_abort_entries_match(
if ( {CONF_HOST: user_input[CONF_HOST], CONF_PORT: user_input[CONF_PORT]}
entry.data[CONF_HOST] == user_input[CONF_HOST] )
and entry.data[CONF_PORT] == user_input[CONF_PORT]
):
return self.async_abort(reason="already_configured")
try: try:
await get_api(self.hass, user_input) await get_api(self.hass, user_input)

4
homeassistant/components/transmission/coordinator.py
View file

@ -71,12 +71,12 @@ class TransmissionDataUpdateCoordinator(DataUpdateCoordinator[SessionStats]):
data = self.api.session_stats() data = self.api.session_stats()
self.torrents = self.api.get_torrents() self.torrents = self.api.get_torrents()
self._session = self.api.get_session() self._session = self.api.get_session()
except transmission_rpc.TransmissionError as err:
raise UpdateFailed("Unable to connect to Transmission client") from err
self.check_completed_torrent() self.check_completed_torrent()
self.check_started_torrent() self.check_started_torrent()
self.check_removed_torrent() self.check_removed_torrent()
except transmission_rpc.TransmissionError as err:
raise UpdateFailed("Unable to connect to Transmission client") from err
return data return data

2
homeassistant/components/transmission/strings.json
View file

@ -30,9 +30,7 @@
"options": { "options": {
"step": { "step": {
"init": { "init": {
"title": "Configure options for Transmission",
"data": { "data": {
"scan_interval": "Update frequency",
"limit": "Limit", "limit": "Limit",
"order": "Order" "order": "Order"
} }