From 60d7e32f811478c8f022db3453c91c53a7765e01 Mon Sep 17 00:00:00 2001 From: Paulus Schoutsen Date: Mon, 5 Mar 2018 14:13:18 -0800 Subject: [PATCH] Flaky tests (#12931) * Skip flaky DDWRT tests * Import APNS before running tests --- .coveragerc | 1 + tests/components/device_tracker/test_ddwrt.py | 3 +++ tests/components/notify/test_apns.py | 3 +-- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.coveragerc b/.coveragerc index 156f546fefb..83d143f83cb 100644 --- a/.coveragerc +++ b/.coveragerc @@ -367,6 +367,7 @@ omit = homeassistant/components/device_tracker/bluetooth_tracker.py homeassistant/components/device_tracker/bt_home_hub_5.py homeassistant/components/device_tracker/cisco_ios.py + homeassistant/components/device_tracker/ddwrt.py homeassistant/components/device_tracker/fritz.py homeassistant/components/device_tracker/gpslogger.py homeassistant/components/device_tracker/hitron_coda.py diff --git a/tests/components/device_tracker/test_ddwrt.py b/tests/components/device_tracker/test_ddwrt.py index 57aeba5b9a5..416b7be4a8a 100644 --- a/tests/components/device_tracker/test_ddwrt.py +++ b/tests/components/device_tracker/test_ddwrt.py @@ -7,6 +7,8 @@ import re import requests import requests_mock +import pytest + from homeassistant import config from homeassistant.setup import setup_component from homeassistant.components import device_tracker @@ -25,6 +27,7 @@ TEST_HOST = '127.0.0.1' _LOGGER = logging.getLogger(__name__) +@pytest.mark.skip class TestDdwrt(unittest.TestCase): """Tests for the Ddwrt device tracker platform.""" diff --git a/tests/components/notify/test_apns.py b/tests/components/notify/test_apns.py index 7715ff168be..0bd0333a6fb 100644 --- a/tests/components/notify/test_apns.py +++ b/tests/components/notify/test_apns.py @@ -3,6 +3,7 @@ import io import unittest from unittest.mock import Mock, patch, mock_open +from apns2.errors import Unregistered import yaml import homeassistant.components.notify as notify @@ -358,8 +359,6 @@ class TestApns(unittest.TestCase): @patch('homeassistant.components.notify.apns._write_device') def test_disable_when_unregistered(self, mock_write, mock_client): """Test disabling a device when it is unregistered.""" - from apns2.errors import Unregistered - send = mock_client.return_value.send_notification send.side_effect = Unregistered()