evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Correct supported_features and model for Mill (#59996)

Browse source 
* Correct supported_features and model for Mill

Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>

* Correct supported_features and model for Mill

Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>

* revert

Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>

* Mill

Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
This commit is contained in:
Daniel Hjelseth Høyer 2021-11-19 23:19:56 +01:00 • committed by GitHub
parent 4f89ce4fb8
commit 5f8646600f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
homeassistant/components/mill/climate.py
View file

@ -86,7 +86,6 @@ class MillHeater(CoordinatorEntity, ClimateEntity):
_attr_fan_modes = [FAN_ON, HVAC_MODE_OFF] _attr_fan_modes = [FAN_ON, HVAC_MODE_OFF]
_attr_max_temp = MAX_TEMP _attr_max_temp = MAX_TEMP
_attr_min_temp = MIN_TEMP _attr_min_temp = MIN_TEMP
_attr_supported_features = SUPPORT_TARGET_TEMPERATURE | SUPPORT_FAN_MODE
_attr_target_temperature_step = PRECISION_WHOLE _attr_target_temperature_step = PRECISION_WHOLE
_attr_temperature_unit = TEMP_CELSIUS _attr_temperature_unit = TEMP_CELSIUS
@ -103,13 +102,21 @@ class MillHeater(CoordinatorEntity, ClimateEntity):
self._attr_device_info = DeviceInfo( self._attr_device_info = DeviceInfo(
identifiers={(DOMAIN, heater.device_id)}, identifiers={(DOMAIN, heater.device_id)},
manufacturer=MANUFACTURER, manufacturer=MANUFACTURER,
model=f"generation {1 if heater.is_gen1 else 2}", model=f"Generation {heater.generation}",
name=self.name, name=self.name,
) )
if heater.is_gen1 or heater.is_gen3: if heater.is_gen1 or heater.is_gen3:
self._attr_hvac_modes = [HVAC_MODE_HEAT] self._attr_hvac_modes = [HVAC_MODE_HEAT]
else: else:
self._attr_hvac_modes = [HVAC_MODE_HEAT, HVAC_MODE_OFF] self._attr_hvac_modes = [HVAC_MODE_HEAT, HVAC_MODE_OFF]
if heater.generation < 3:
self._attr_supported_features = (
SUPPORT_TARGET_TEMPERATURE | SUPPORT_FAN_MODE
)
else:
self._attr_supported_features = SUPPORT_TARGET_TEMPERATURE
self._update_attr(heater) self._update_attr(heater)
async def async_set_temperature(self, **kwargs): async def async_set_temperature(self, **kwargs):
@ -162,7 +169,7 @@ class MillHeater(CoordinatorEntity, ClimateEntity):
"open_window": heater.open_window, "open_window": heater.open_window,
"heating": heater.is_heating, "heating": heater.is_heating,
"controlled_by_tibber": heater.tibber_control, "controlled_by_tibber": heater.tibber_control,
"heater_generation": 1 if heater.is_gen1 else 2, "heater_generation": heater.generation,
} }
if heater.room: if heater.room:
self._attr_extra_state_attributes["room"] = heater.room.name self._attr_extra_state_attributes["room"] = heater.room.name