From 5f576485781e2a8e954bb2f19d86467ee3f42ef1 Mon Sep 17 00:00:00 2001 From: Maciej Bieniek Date: Mon, 30 Jan 2023 14:29:06 +0100 Subject: [PATCH] Use more human-readable sensor names in Airly (#86893) * Use more human-readable sensor names * Use abbreviations for long names --- homeassistant/components/airly/sensor.py | 10 +++++----- tests/components/airly/test_sensor.py | 20 ++++++++++---------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/homeassistant/components/airly/sensor.py b/homeassistant/components/airly/sensor.py index a591d5f538f..93f6d26e145 100644 --- a/homeassistant/components/airly/sensor.py +++ b/homeassistant/components/airly/sensor.py @@ -80,7 +80,7 @@ SENSOR_TYPES: tuple[AirlySensorEntityDescription, ...] = ( AirlySensorEntityDescription( key=ATTR_API_PM1, device_class=SensorDeviceClass.PM1, - name=ATTR_API_PM1, + name="PM1.0", native_precision=0, native_unit_of_measurement=CONCENTRATION_MICROGRAMS_PER_CUBIC_METER, state_class=SensorStateClass.MEASUREMENT, @@ -135,7 +135,7 @@ SENSOR_TYPES: tuple[AirlySensorEntityDescription, ...] = ( ), AirlySensorEntityDescription( key=ATTR_API_CO, - name=ATTR_API_CO, + name="Carbon monoxide", native_precision=0, native_unit_of_measurement=CONCENTRATION_MICROGRAMS_PER_CUBIC_METER, state_class=SensorStateClass.MEASUREMENT, @@ -147,7 +147,7 @@ SENSOR_TYPES: tuple[AirlySensorEntityDescription, ...] = ( AirlySensorEntityDescription( key=ATTR_API_NO2, device_class=SensorDeviceClass.NITROGEN_DIOXIDE, - name=ATTR_API_NO2, + name="Nitrogen dioxide", native_precision=0, native_unit_of_measurement=CONCENTRATION_MICROGRAMS_PER_CUBIC_METER, state_class=SensorStateClass.MEASUREMENT, @@ -159,7 +159,7 @@ SENSOR_TYPES: tuple[AirlySensorEntityDescription, ...] = ( AirlySensorEntityDescription( key=ATTR_API_SO2, device_class=SensorDeviceClass.SULPHUR_DIOXIDE, - name=ATTR_API_SO2, + name="Sulphur dioxide", native_precision=0, native_unit_of_measurement=CONCENTRATION_MICROGRAMS_PER_CUBIC_METER, state_class=SensorStateClass.MEASUREMENT, @@ -171,7 +171,7 @@ SENSOR_TYPES: tuple[AirlySensorEntityDescription, ...] = ( AirlySensorEntityDescription( key=ATTR_API_O3, device_class=SensorDeviceClass.OZONE, - name=ATTR_API_O3, + name="Ozone", native_precision=0, native_unit_of_measurement=CONCENTRATION_MICROGRAMS_PER_CUBIC_METER, state_class=SensorStateClass.MEASUREMENT, diff --git a/tests/components/airly/test_sensor.py b/tests/components/airly/test_sensor.py index bdc1e909f35..0501ae4193a 100644 --- a/tests/components/airly/test_sensor.py +++ b/tests/components/airly/test_sensor.py @@ -59,7 +59,7 @@ async def test_sensor(hass, aioclient_mock): assert entry assert entry.unique_id == "123-456-humidity" - state = hass.states.get("sensor.home_pm1") + state = hass.states.get("sensor.home_pm1_0") assert state assert state.state == "3" assert state.attributes.get(ATTR_ATTRIBUTION) == ATTRIBUTION @@ -70,7 +70,7 @@ async def test_sensor(hass, aioclient_mock): assert state.attributes.get(ATTR_DEVICE_CLASS) == SensorDeviceClass.PM1 assert state.attributes.get(ATTR_STATE_CLASS) == SensorStateClass.MEASUREMENT - entry = registry.async_get("sensor.home_pm1") + entry = registry.async_get("sensor.home_pm1_0") assert entry assert entry.unique_id == "123-456-pm1" @@ -104,7 +104,7 @@ async def test_sensor(hass, aioclient_mock): assert entry assert entry.unique_id == "123-456-pm10" - state = hass.states.get("sensor.home_co") + state = hass.states.get("sensor.home_carbon_monoxide") assert state assert state.state == "162" assert state.attributes.get(ATTR_ATTRIBUTION) == ATTRIBUTION @@ -114,11 +114,11 @@ async def test_sensor(hass, aioclient_mock): ) assert state.attributes.get(ATTR_STATE_CLASS) == SensorStateClass.MEASUREMENT - entry = registry.async_get("sensor.home_co") + entry = registry.async_get("sensor.home_carbon_monoxide") assert entry assert entry.unique_id == "123-456-co" - state = hass.states.get("sensor.home_no2") + state = hass.states.get("sensor.home_nitrogen_dioxide") assert state assert state.state == "16" assert state.attributes.get(ATTR_ATTRIBUTION) == ATTRIBUTION @@ -129,11 +129,11 @@ async def test_sensor(hass, aioclient_mock): assert state.attributes.get(ATTR_DEVICE_CLASS) == SensorDeviceClass.NITROGEN_DIOXIDE assert state.attributes.get(ATTR_STATE_CLASS) == SensorStateClass.MEASUREMENT - entry = registry.async_get("sensor.home_no2") + entry = registry.async_get("sensor.home_nitrogen_dioxide") assert entry assert entry.unique_id == "123-456-no2" - state = hass.states.get("sensor.home_o3") + state = hass.states.get("sensor.home_ozone") assert state assert state.state == "42" assert state.attributes.get(ATTR_ATTRIBUTION) == ATTRIBUTION @@ -144,11 +144,11 @@ async def test_sensor(hass, aioclient_mock): assert state.attributes.get(ATTR_DEVICE_CLASS) == SensorDeviceClass.OZONE assert state.attributes.get(ATTR_STATE_CLASS) == SensorStateClass.MEASUREMENT - entry = registry.async_get("sensor.home_o3") + entry = registry.async_get("sensor.home_ozone") assert entry assert entry.unique_id == "123-456-o3" - state = hass.states.get("sensor.home_so2") + state = hass.states.get("sensor.home_sulphur_dioxide") assert state assert state.state == "14" assert state.attributes.get(ATTR_ATTRIBUTION) == ATTRIBUTION @@ -159,7 +159,7 @@ async def test_sensor(hass, aioclient_mock): assert state.attributes.get(ATTR_DEVICE_CLASS) == SensorDeviceClass.SULPHUR_DIOXIDE assert state.attributes.get(ATTR_STATE_CLASS) == SensorStateClass.MEASUREMENT - entry = registry.async_get("sensor.home_so2") + entry = registry.async_get("sensor.home_sulphur_dioxide") assert entry assert entry.unique_id == "123-456-so2"