evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Allow rest sensor list responses (#28835)

Browse source 
* Make rest sensor a little bit more flexible and allow the response to be a list with 0th element being a dictionary

* Black formatter wanted a different formatting

* Added test case for a list response with dict as 0th element

* Fixed lint error - it thinks a + STRING is an avoidance of using % sequences for log messages; I generally prefer explicit + rather than string juxtaposition for combining string literals, but sounds like that's not the standard

* Fixed test case -- I added it to the wrong scenario and need to use the one with json_attrs.
This commit is contained in:
gjbadros 2019-11-26 13:10:58 -08:00 • committed by Fabian Affolter
parent b72c6c4424
commit 5f1b0fb15c
2 changed files with 26 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
homeassistant/components/rest/sensor.py
View file

@ -197,13 +197,18 @@ class RestSensor(Entity):
if value:
try:
json_dict = json.loads(value)
if isinstance(json_dict, list):
json_dict = json_dict[0]
if isinstance(json_dict, dict):
attrs = {
k: json_dict[k] for k in self._json_attrs if k in json_dict
}
self._attributes = attrs
else:
_LOGGER.warning("JSON result was not a dictionary")
_LOGGER.warning(
"JSON result was not a dictionary"
" or list with 0th element a dictionary"
)
except ValueError:
_LOGGER.warning("REST result could not be parsed as JSON")
_LOGGER.debug("Erroneous JSON: %s", value)