evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Enable some more bandit checks (#30857)

Browse source 
* Enable B108 (hardcoded tmp dir), address findings

* Enable B602 (subprocess popen with shell), address findings

* Enable B604 (start process with shell), address findings

* Enable B306 (mktemp), B307 (eval), and B325 (tempnam), no issues to address
This commit is contained in:
Ville Skyttä 2020-01-20 18:44:55 +02:00 • committed by GitHub
parent 6cf20fc7fa
commit 5e2ba2eb77
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
21 changed files with 110 additions and 91 deletions
Download patch file Download diff file Expand all files Collapse all files

8
homeassistant/components/command_line/switch.py
View file

@ -94,7 +94,7 @@ class CommandSwitch(SwitchDevice):
"""Execute the actual commands."""
_LOGGER.info("Running command: %s", command)
success = subprocess.call(command, shell=True) == 0
success = subprocess.call(command, shell=True) == 0 # nosec # shell by design
if not success:
_LOGGER.error("Command failed: %s", command)
@ -107,7 +107,9 @@ class CommandSwitch(SwitchDevice):
_LOGGER.info("Running state command: %s", command)
try:
return_value = subprocess.check_output(command, shell=True)
return_value = subprocess.check_output(
command, shell=True # nosec # shell by design
)
return return_value.strip().decode("utf-8")
except subprocess.CalledProcessError:
_LOGGER.error("Command failed: %s", command)
@ -116,7 +118,7 @@ class CommandSwitch(SwitchDevice):
def _query_state_code(command):
"""Execute state command for return code."""
_LOGGER.info("Running state command: %s", command)
return subprocess.call(command, shell=True) == 0
return subprocess.call(command, shell=True) == 0 # nosec # shell by design
@property
def should_poll(self):