evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Indicate in statistics issues when units can be converted (#79121)

Browse source
This commit is contained in:
Erik Montnemery 2022-09-27 13:51:38 +02:00 • committed by GitHub
parent 2167cf540d
commit 5bcef1c7ce
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 225 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

19
homeassistant/components/sensor/recorder.py
View file

@ -670,11 +670,16 @@ def validate_statistics(
metadata_unit = metadata[1]["unit_of_measurement"]
if device_class not in UNIT_CONVERTERS:
issue_type = (
"units_changed_can_convert"
if statistics.can_convert_units(metadata_unit, state_unit)
else "units_changed"
)
if state_unit != metadata_unit:
# The unit has changed
validation_result[entity_id].append(
statistics.ValidationIssue(
"units_changed",
issue_type,
{
"statistic_id": entity_id,
"state_unit": state_unit,
@ -684,16 +689,20 @@ def validate_statistics(
)
elif metadata_unit != UNIT_CONVERTERS[device_class].NORMALIZED_UNIT:
# The unit in metadata is not supported for this device class
statistics_unit = UNIT_CONVERTERS[device_class].NORMALIZED_UNIT
issue_type = (
"unsupported_unit_metadata_can_convert"
if statistics.can_convert_units(metadata_unit, statistics_unit)
else "unsupported_unit_metadata"
)
validation_result[entity_id].append(
statistics.ValidationIssue(
"unsupported_unit_metadata",
issue_type,
{
"statistic_id": entity_id,
"device_class": device_class,
"metadata_unit": metadata_unit,
"supported_unit": UNIT_CONVERTERS[
device_class
].NORMALIZED_UNIT,
"supported_unit": statistics_unit,
},
)
)