From 57bec29266b56832d6ded9919bdc496823c33265 Mon Sep 17 00:00:00 2001 From: Maciej Bieniek Date: Fri, 9 Feb 2024 23:28:24 +0100 Subject: [PATCH] Add icon translations to NAM (#110135) Co-authored-by: Maciej Bieniek <478555+bieniu@users.noreply.github.com> --- homeassistant/components/nam/icons.json | 27 +++++++++++++++++++++++++ homeassistant/components/nam/sensor.py | 7 ------- tests/components/nam/test_sensor.py | 14 ++++++------- 3 files changed, 34 insertions(+), 14 deletions(-) create mode 100644 homeassistant/components/nam/icons.json diff --git a/homeassistant/components/nam/icons.json b/homeassistant/components/nam/icons.json new file mode 100644 index 00000000000..5e55bf145e5 --- /dev/null +++ b/homeassistant/components/nam/icons.json @@ -0,0 +1,27 @@ +{ + "entity": { + "sensor": { + "pmsx003_caqi": { + "default": "mdi:air-filter" + }, + "pmsx003_caqi_level": { + "default": "mdi:air-filter" + }, + "sds011_caqi": { + "default": "mdi:air-filter" + }, + "sds011_caqi_level": { + "default": "mdi:air-filter" + }, + "sps30_caqi": { + "default": "mdi:air-filter" + }, + "sps30_caqi_level": { + "default": "mdi:air-filter" + }, + "sps30_pm4": { + "default": "mdi:molecule" + } + } + } +} diff --git a/homeassistant/components/nam/sensor.py b/homeassistant/components/nam/sensor.py index 5b3c6517f64..cd1543affa2 100644 --- a/homeassistant/components/nam/sensor.py +++ b/homeassistant/components/nam/sensor.py @@ -180,13 +180,11 @@ SENSORS: tuple[NAMSensorEntityDescription, ...] = ( NAMSensorEntityDescription( key=ATTR_PMSX003_CAQI, translation_key="pmsx003_caqi", - icon="mdi:air-filter", value=lambda sensors: sensors.pms_caqi, ), NAMSensorEntityDescription( key=ATTR_PMSX003_CAQI_LEVEL, translation_key="pmsx003_caqi_level", - icon="mdi:air-filter", device_class=SensorDeviceClass.ENUM, options=["very_low", "low", "medium", "high", "very_high"], value=lambda sensors: sensors.pms_caqi_level, @@ -221,13 +219,11 @@ SENSORS: tuple[NAMSensorEntityDescription, ...] = ( NAMSensorEntityDescription( key=ATTR_SDS011_CAQI, translation_key="sds011_caqi", - icon="mdi:air-filter", value=lambda sensors: sensors.sds011_caqi, ), NAMSensorEntityDescription( key=ATTR_SDS011_CAQI_LEVEL, translation_key="sds011_caqi_level", - icon="mdi:air-filter", device_class=SensorDeviceClass.ENUM, options=["very_low", "low", "medium", "high", "very_high"], value=lambda sensors: sensors.sds011_caqi_level, @@ -271,13 +267,11 @@ SENSORS: tuple[NAMSensorEntityDescription, ...] = ( NAMSensorEntityDescription( key=ATTR_SPS30_CAQI, translation_key="sps30_caqi", - icon="mdi:air-filter", value=lambda sensors: sensors.sps30_caqi, ), NAMSensorEntityDescription( key=ATTR_SPS30_CAQI_LEVEL, translation_key="sps30_caqi_level", - icon="mdi:air-filter", device_class=SensorDeviceClass.ENUM, options=["very_low", "low", "medium", "high", "very_high"], value=lambda sensors: sensors.sps30_caqi_level, @@ -314,7 +308,6 @@ SENSORS: tuple[NAMSensorEntityDescription, ...] = ( translation_key="sps30_pm4", suggested_display_precision=0, native_unit_of_measurement=CONCENTRATION_MICROGRAMS_PER_CUBIC_METER, - icon="mdi:molecule", state_class=SensorStateClass.MEASUREMENT, value=lambda sensors: sensors.sps30_p4, ), diff --git a/tests/components/nam/test_sensor.py b/tests/components/nam/test_sensor.py index 50cf3aba659..80eedd5b1a3 100644 --- a/tests/components/nam/test_sensor.py +++ b/tests/components/nam/test_sensor.py @@ -241,7 +241,7 @@ async def test_sensor(hass: HomeAssistant, entity_registry: er.EntityRegistry) - "high", "very_high", ] - assert state.attributes.get(ATTR_ICON) == "mdi:air-filter" + assert state.attributes.get(ATTR_ICON) is None entry = entity_registry.async_get( "sensor.nettigo_air_monitor_pmsx003_common_air_quality_index_level" @@ -255,7 +255,7 @@ async def test_sensor(hass: HomeAssistant, entity_registry: er.EntityRegistry) - ) assert state assert state.state == "19" - assert state.attributes.get(ATTR_ICON) == "mdi:air-filter" + assert state.attributes.get(ATTR_ICON) is None entry = entity_registry.async_get( "sensor.nettigo_air_monitor_pmsx003_common_air_quality_index" @@ -324,7 +324,7 @@ async def test_sensor(hass: HomeAssistant, entity_registry: er.EntityRegistry) - ) assert state assert state.state == "19" - assert state.attributes.get(ATTR_ICON) == "mdi:air-filter" + assert state.attributes.get(ATTR_ICON) is None entry = entity_registry.async_get( "sensor.nettigo_air_monitor_sds011_common_air_quality_index" @@ -345,7 +345,7 @@ async def test_sensor(hass: HomeAssistant, entity_registry: er.EntityRegistry) - "high", "very_high", ] - assert state.attributes.get(ATTR_ICON) == "mdi:air-filter" + assert state.attributes.get(ATTR_ICON) is None entry = entity_registry.async_get( "sensor.nettigo_air_monitor_sds011_common_air_quality_index_level" @@ -371,7 +371,7 @@ async def test_sensor(hass: HomeAssistant, entity_registry: er.EntityRegistry) - state = hass.states.get("sensor.nettigo_air_monitor_sps30_common_air_quality_index") assert state assert state.state == "54" - assert state.attributes.get(ATTR_ICON) == "mdi:air-filter" + assert state.attributes.get(ATTR_ICON) is None entry = entity_registry.async_get( "sensor.nettigo_air_monitor_sps30_common_air_quality_index" @@ -392,7 +392,7 @@ async def test_sensor(hass: HomeAssistant, entity_registry: er.EntityRegistry) - "high", "very_high", ] - assert state.attributes.get(ATTR_ICON) == "mdi:air-filter" + assert state.attributes.get(ATTR_ICON) is None entry = entity_registry.async_get( "sensor.nettigo_air_monitor_sps30_common_air_quality_index_level" @@ -451,7 +451,7 @@ async def test_sensor(hass: HomeAssistant, entity_registry: er.EntityRegistry) - state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) == CONCENTRATION_MICROGRAMS_PER_CUBIC_METER ) - assert state.attributes.get(ATTR_ICON) == "mdi:molecule" + assert state.attributes.get(ATTR_ICON) is None entry = entity_registry.async_get("sensor.nettigo_air_monitor_sps30_pm4") assert entry