evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Bugfix invalid entity_config parameter HomeKit ()

Browse source
This commit is contained in:
cdce8p 2018-10-04 20:37:04 +02:00 • committed by GitHub
parent 769dda735d
commit 52ff232797
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
homeassistant/components/homekit
util.py
tests/components/homekit
test_util.py

3
homeassistant/components/homekit/util.py
View file

@ -44,6 +44,9 @@ SWITCH_TYPE_SCHEMA = BASIC_INFO_SCHEMA.extend({
def validate_entity_config(values): def validate_entity_config(values):
"""Validate config entry for CONF_ENTITY.""" """Validate config entry for CONF_ENTITY."""
if not isinstance(values, dict):
raise vol.Invalid('expected a dictionary')
entities = {} entities = {}
for entity_id, config in values.items(): for entity_id, config in values.items():
entity = cv.entity_id(entity_id) entity = cv.entity_id(entity_id)

3
tests/components/homekit/test_util.py
View file

@ -23,7 +23,8 @@ from tests.common import async_mock_service
def test_validate_entity_config(): def test_validate_entity_config():
"""Test validate entities.""" """Test validate entities."""
configs = [{'invalid_entity_id': {}}, {'demo.test': 1}, configs = [None, [], 'string', 12345,
{'invalid_entity_id': {}}, {'demo.test': 1},
{'demo.test': 'test'}, {'demo.test': [1, 2]}, {'demo.test': 'test'}, {'demo.test': [1, 2]},
{'demo.test': None}, {'demo.test': {CONF_NAME: None}}, {'demo.test': None}, {'demo.test': {CONF_NAME: None}},
{'media_player.test': {CONF_FEATURE_LIST: [ {'media_player.test': {CONF_FEATURE_LIST: [