evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add config option to set timeout for wiffi devices (#35694)

Browse source 
* add config option to set timeout for wiffi devices

Wiffi devices allow to configure the update period (=
full_loop_minutes). The integration shall respect the configured update
period and therefore need a configuration for the timeout, too.

* Move timeout from config flow to option flow

* add test for option flow
This commit is contained in:
Steffen Zimmermann 2020-05-17 10:31:28 +02:00 • committed by GitHub
parent d02bb70f0c
commit 51eebb3906
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 112 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

35
tests/components/wiffi/test_config_flow.py
View file

@ -4,15 +4,19 @@ import errno
from asynctest import patch
import pytest
from homeassistant import config_entries
from homeassistant import config_entries, data_entry_flow
from homeassistant.components.wiffi.const import DOMAIN
from homeassistant.const import CONF_PORT
from homeassistant.const import CONF_PORT, CONF_TIMEOUT
from homeassistant.data_entry_flow import (
RESULT_TYPE_ABORT,
RESULT_TYPE_CREATE_ENTRY,
RESULT_TYPE_FORM,
)
from tests.common import MockConfigEntry
MOCK_CONFIG = {CONF_PORT: 8765}
@pytest.fixture(name="dummy_tcp_server")
def mock_dummy_tcp_server():
@ -78,7 +82,7 @@ async def test_form(hass, dummy_tcp_server):
assert result["step_id"] == config_entries.SOURCE_USER
result2 = await hass.config_entries.flow.async_configure(
result["flow_id"], user_input={CONF_PORT: 8765},
result["flow_id"], user_input=MOCK_CONFIG,
)
assert result2["type"] == RESULT_TYPE_CREATE_ENTRY
@ -90,7 +94,7 @@ async def test_form_addr_in_use(hass, addr_in_use):
)
result2 = await hass.config_entries.flow.async_configure(
result["flow_id"], user_input={CONF_PORT: 8765},
result["flow_id"], user_input=MOCK_CONFIG,
)
assert result2["type"] == RESULT_TYPE_ABORT
assert result2["reason"] == "addr_in_use"
@ -103,7 +107,28 @@ async def test_form_start_server_failed(hass, start_server_failed):
)
result2 = await hass.config_entries.flow.async_configure(
result["flow_id"], user_input={CONF_PORT: 8765},
result["flow_id"], user_input=MOCK_CONFIG,
)
assert result2["type"] == RESULT_TYPE_ABORT
assert result2["reason"] == "start_server_failed"
async def test_option_flow(hass):
"""Test option flow."""
entry = MockConfigEntry(domain=DOMAIN, data=MOCK_CONFIG)
entry.add_to_hass(hass)
assert not entry.options
result = await hass.config_entries.options.async_init(entry.entry_id, data=None)
assert result["type"] == data_entry_flow.RESULT_TYPE_FORM
assert result["step_id"] == "init"
result = await hass.config_entries.options.async_configure(
result["flow_id"], user_input={CONF_TIMEOUT: 9}
)
assert result["type"] == data_entry_flow.RESULT_TYPE_CREATE_ENTRY
assert result["title"] == ""
assert result["data"][CONF_TIMEOUT] == 9