evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve code quality of TCP platform (#51000)

Browse source 
* Improve code placements

* Fix entity inheritance

* fix tests

* Improve PLATFORM_SCHEMA handling

* Apply suggestions
This commit is contained in:
Michael 2021-05-24 12:03:43 +02:00 • committed by GitHub
parent 870c61a622
commit 51c8b1eb0b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 175 additions and 156 deletions
Download patch file Download diff file Expand all files Collapse all files

11
homeassistant/components/tcp/binary_sensor.py
View file

@ -3,15 +3,18 @@ from __future__ import annotations
from typing import Any, Final
from homeassistant.components.binary_sensor import BinarySensorEntity
from homeassistant.components.binary_sensor import (
PLATFORM_SCHEMA as PARENT_PLATFORM_SCHEMA,
BinarySensorEntity,
)
from homeassistant.core import HomeAssistant
from homeassistant.helpers.entity_platform import AddEntitiesCallback
from homeassistant.helpers.typing import ConfigType
from .common import TCP_PLATFORM_SCHEMA, TcpEntity
from .const import CONF_VALUE_ON
from .sensor import PLATFORM_SCHEMA as TCP_PLATFORM_SCHEMA, TcpSensor
PLATFORM_SCHEMA: Final = TCP_PLATFORM_SCHEMA
PLATFORM_SCHEMA: Final = PARENT_PLATFORM_SCHEMA.extend(TCP_PLATFORM_SCHEMA)
def setup_platform(
@ -24,7 +27,7 @@ def setup_platform(
add_entities([TcpBinarySensor(hass, config)])
class TcpBinarySensor(BinarySensorEntity, TcpSensor):
class TcpBinarySensor(TcpEntity, BinarySensorEntity):
"""A binary sensor which is on when its state == CONF_VALUE_ON."""
@property