Activate hassfest requirements CI check (#39940)

Co-authored-by: Franck Nijhof <git@frenck.dev>

.github/workflows/ci.yaml

@@ -518,25 +518,24 @@ jobs:
   hassfest:
     name: Check hassfest
     runs-on: ubuntu-latest
-    needs: prepare-base
+    needs: prepare-tests
+    strategy:
+      matrix:
+        python-version: [3.7]
+    container: homeassistant/ci-azure:${{ matrix.python-version }}
     steps:
       - name: Check out code from GitHub
         uses: actions/checkout@v2
-      - name: Set up Python ${{ env.DEFAULT_PYTHON }}
+      - name:
-        uses: actions/setup-python@v2.1.2
+          Restore full Python ${{ matrix.python-version }} virtual environment
-        id: python
-        with:
-          python-version: ${{ env.DEFAULT_PYTHON }}
-      - name: Restore base Python virtual environment
         id: cache-venv
         uses: actions/cache@v2
         with:
           path: venv
           key: >-
-            ${{ env.CACHE_VERSION}}-${{ runner.os }}-base-venv-${{
+            ${{ env.CACHE_VERSION}}-${{ runner.os }}-venv-${{
-            steps.python.outputs.python-version }}-${{
+            matrix.python-version }}-${{ hashFiles('requirements_test.txt')
-            hashFiles('requirements.txt') }}-${{
+            }}-${{ hashFiles('requirements_all.txt') }}-${{
-            hashFiles('requirements_test.txt') }}-${{
             hashFiles('homeassistant/package_constraints.txt') }}
       - name: Fail job if Python cache restore failed
         if: steps.cache-venv.outputs.cache-hit != 'true'
@@ -546,7 +545,7 @@ jobs:
       - name: Run hassfest
         run: |
           . venv/bin/activate
-          python -m script.hassfest --action validate
+          python -m script.hassfest --requirements --action validate
 
   gen-requirements-all:
     name: Check all requirements

homeassistant/components/homekit_controller/manifest.json

@@ -3,8 +3,16 @@
   "name": "HomeKit Controller",
   "config_flow": true,
   "documentation": "https://www.home-assistant.io/integrations/homekit_controller",
-  "requirements": ["aiohomekit[IP]==0.2.49"],
+  "requirements": [
-  "zeroconf": ["_hap._tcp.local."],
+    "aiohomekit==0.2.49"
-  "after_dependencies": ["zeroconf"],
+  ],
-  "codeowners": ["@Jc2k"]
+  "zeroconf": [
+    "_hap._tcp.local."
+  ],
+  "after_dependencies": [
+    "zeroconf"
+  ],
+  "codeowners": [
+    "@Jc2k"
+  ]
 }

homeassistant/components/samsungtv/manifest.json

@@ -4,13 +4,15 @@
   "documentation": "https://www.home-assistant.io/integrations/samsungtv",
   "requirements": [
     "samsungctl[websocket]==0.7.1",
-    "samsungtvws[websocket]==1.4.0"
+    "samsungtvws==1.4.0"
   ],
   "ssdp": [
     {
       "st": "urn:samsung.com:device:RemoteControlReceiver:1"
     }
   ],
-  "codeowners": ["@escoand"],
+  "codeowners": [
+    "@escoand"
+  ],
   "config_flow": true
 }

requirements_all.txt

@@ -2,7 +2,7 @@
 -r requirements.txt
 
 # homeassistant.components.nuimo_controller
---only-binary=all nuimo==0.1.0
+# --only-binary=all nuimo==0.1.0
 
 # homeassistant.components.dht
 # Adafruit-DHT==1.4.0
@@ -178,7 +178,7 @@ aioguardian==1.0.1
 aioharmony==0.2.6
 
 # homeassistant.components.homekit_controller
-aiohomekit[IP]==0.2.49
+aiohomekit==0.2.49
 
 # homeassistant.components.emulated_hue
 # homeassistant.components.http
@@ -1942,7 +1942,7 @@ saltbox==0.1.3
 samsungctl[websocket]==0.7.1
 
 # homeassistant.components.samsungtv
-samsungtvws[websocket]==1.4.0
+samsungtvws==1.4.0
 
 # homeassistant.components.satel_integra
 satel_integra==0.3.4

requirements_test_all.txt

@@ -103,7 +103,7 @@ aioguardian==1.0.1
 aioharmony==0.2.6
 
 # homeassistant.components.homekit_controller
-aiohomekit[IP]==0.2.49
+aiohomekit==0.2.49
 
 # homeassistant.components.emulated_hue
 # homeassistant.components.http
@@ -905,7 +905,7 @@ rxv==0.6.0
 samsungctl[websocket]==0.7.1
 
 # homeassistant.components.samsungtv
-samsungtvws[websocket]==1.4.0
+samsungtvws==1.4.0
 
 # homeassistant.components.emulated_kasa
 # homeassistant.components.sense

script/gen_requirements_all.py

@@ -23,11 +23,13 @@ COMMENT_REQUIREMENTS = (
     "bme680",
     "credstash",
     "decora",
+    "decora_wifi",
     "env_canada",
     "envirophat",
     "evdev",
     "face_recognition",
     "i2csense",
+    "nuimo",
     "opencv-python-headless",
     "py_noaa",
     "pybluez",

script/hassfest/requirements.py

@@ -2,6 +2,7 @@
 from collections import deque
 import json
 import operator
+import os
 import re
 import subprocess
 import sys
@@ -31,6 +32,19 @@ SUPPORTED_PYTHON_VERSIONS = [
 STD_LIBS = {version: set(stdlib_list(version)) for version in SUPPORTED_PYTHON_VERSIONS}
 PIPDEPTREE_CACHE = None
 
+IGNORE_VIOLATIONS = {
+    # Still has standard library requirements.
+    "acmeda",
+    "blink",
+    "ezviz",
+    "hdmi_cec",
+    "juicenet",
+    "lupusec",
+    "rainbird",
+    "slide",
+    "suez_water",
+}
+
 
 def normalize_package_name(requirement: str) -> str:
     """Return a normalized package name from a requirement string."""
@@ -49,12 +63,10 @@ def validate(integrations: Dict[str, Integration], config: Config):
     ensure_cache()
 
     # check for incompatible requirements
-    items = integrations.values()
 
-    if not config.specific_integrations:
+    disable_tqdm = config.specific_integrations or os.environ.get("CI", False)
-        tqdm(items)
 
-    for integration in items:
+    for integration in tqdm(integrations.values(), disable=disable_tqdm):
         if not integration.manifest:
             continue
 
@@ -63,6 +75,10 @@ def validate(integrations: Dict[str, Integration], config: Config):
 
 def validate_requirements(integration: Integration):
     """Validate requirements."""
+    # Some integrations have not been fixed yet so are allowed to have violations.
+    if integration.domain in IGNORE_VIOLATIONS:
+        return
+
     integration_requirements = set()
     integration_packages = set()
     for req in integration.requirements: