From 4e460f71f8960b7de4caf71d842d96a691365186 Mon Sep 17 00:00:00 2001
From: Renier Moorcroft <66512715+RenierM26@users.noreply.github.com>
Date: Thu, 20 Jul 2023 10:35:06 +0200
Subject: [PATCH] Add EZVIZ BinarySensorEntity proper names and translation key
 (#95698)

* Update binary_sensor.py

* Add proper naming and translation keys

* Apply suggestions from code review

Co-authored-by: G Johansson <goran.johansson@shiftit.se>

* Fix strings after merge.

---------

Co-authored-by: G Johansson <goran.johansson@shiftit.se>
---
 homeassistant/components/ezviz/binary_sensor.py | 11 ++++++++---
 homeassistant/components/ezviz/strings.json     |  8 ++++++++
 2 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/homeassistant/components/ezviz/binary_sensor.py b/homeassistant/components/ezviz/binary_sensor.py
index 77e95fa221d..3ed61d8fc3d 100644
--- a/homeassistant/components/ezviz/binary_sensor.py
+++ b/homeassistant/components/ezviz/binary_sensor.py
@@ -22,9 +22,13 @@ BINARY_SENSOR_TYPES: dict[str, BinarySensorEntityDescription] = {
         device_class=BinarySensorDeviceClass.MOTION,
     ),
     "alarm_schedules_enabled": BinarySensorEntityDescription(
-        key="alarm_schedules_enabled"
+        key="alarm_schedules_enabled",
+        translation_key="alarm_schedules_enabled",
+    ),
+    "encrypted": BinarySensorEntityDescription(
+        key="encrypted",
+        translation_key="encrypted",
     ),
-    "encrypted": BinarySensorEntityDescription(key="encrypted"),
 }
 
 
@@ -50,6 +54,8 @@ async def async_setup_entry(
 class EzvizBinarySensor(EzvizEntity, BinarySensorEntity):
     """Representation of a EZVIZ sensor."""
 
+    _attr_has_entity_name = True
+
     def __init__(
         self,
         coordinator: EzvizDataUpdateCoordinator,
@@ -59,7 +65,6 @@ class EzvizBinarySensor(EzvizEntity, BinarySensorEntity):
         """Initialize the sensor."""
         super().__init__(coordinator, serial)
         self._sensor_name = binary_sensor
-        self._attr_name = f"{self._camera_name} {binary_sensor.title()}"
         self._attr_unique_id = f"{serial}_{self._camera_name}.{binary_sensor}"
         self.entity_description = BINARY_SENSOR_TYPES[binary_sensor]
 
diff --git a/homeassistant/components/ezviz/strings.json b/homeassistant/components/ezviz/strings.json
index 909a9b5f9c0..0245edc0e3e 100644
--- a/homeassistant/components/ezviz/strings.json
+++ b/homeassistant/components/ezviz/strings.json
@@ -99,6 +99,14 @@
         "name": "Last motion image"
       }
     },
+    "binary_sensor": {
+      "alarm_schedules_enabled": {
+        "name": "Alarm schedules enabled"
+      },
+      "encrypted": {
+        "name": "Encryption"
+      }
+    },
     "sensor": {
       "alarm_sound_mod": {
         "name": "Alarm sound level"