From 4d660f926db0fa87dd2a0226bf8ba983825fc776 Mon Sep 17 00:00:00 2001 From: epenet <6771947+epenet@users.noreply.github.com> Date: Tue, 10 Jan 2023 16:37:04 +0100 Subject: [PATCH] Fix unknown data in google wifi (#85616) --- homeassistant/components/google_wifi/sensor.py | 17 ++++++++--------- tests/components/google_wifi/test_sensor.py | 5 ++--- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/homeassistant/components/google_wifi/sensor.py b/homeassistant/components/google_wifi/sensor.py index d7be81a8ea5..9fe264219ec 100644 --- a/homeassistant/components/google_wifi/sensor.py +++ b/homeassistant/components/google_wifi/sensor.py @@ -17,7 +17,6 @@ from homeassistant.const import ( CONF_HOST, CONF_MONITORED_CONDITIONS, CONF_NAME, - STATE_UNKNOWN, UnitOfTime, ) from homeassistant.core import HomeAssistant @@ -172,12 +171,12 @@ class GoogleWifiAPI: self.raw_data = None self.conditions = conditions self.data = { - ATTR_CURRENT_VERSION: STATE_UNKNOWN, - ATTR_NEW_VERSION: STATE_UNKNOWN, - ATTR_UPTIME: STATE_UNKNOWN, - ATTR_LAST_RESTART: STATE_UNKNOWN, - ATTR_LOCAL_IP: STATE_UNKNOWN, - ATTR_STATUS: STATE_UNKNOWN, + ATTR_CURRENT_VERSION: None, + ATTR_NEW_VERSION: None, + ATTR_UPTIME: None, + ATTR_LAST_RESTART: None, + ATTR_LOCAL_IP: None, + ATTR_STATUS: None, } self.available = True self.update() @@ -223,7 +222,7 @@ class GoogleWifiAPI: elif ( attr_key == ATTR_LOCAL_IP and not self.raw_data["wan"]["online"] ): - sensor_value = STATE_UNKNOWN + sensor_value = None self.data[attr_key] = sensor_value except KeyError: @@ -235,4 +234,4 @@ class GoogleWifiAPI: description.sensor_key, attr_key, ) - self.data[attr_key] = STATE_UNKNOWN + self.data[attr_key] = None diff --git a/tests/components/google_wifi/test_sensor.py b/tests/components/google_wifi/test_sensor.py index ae0715c640b..30493a6011b 100644 --- a/tests/components/google_wifi/test_sensor.py +++ b/tests/components/google_wifi/test_sensor.py @@ -4,7 +4,6 @@ from http import HTTPStatus from unittest.mock import Mock, patch import homeassistant.components.google_wifi.sensor as google_wifi -from homeassistant.const import STATE_UNKNOWN from homeassistant.setup import async_setup_component from homeassistant.util import dt as dt_util @@ -171,7 +170,7 @@ def test_update_when_value_changed(hass, requests_mock): elif name == google_wifi.ATTR_NEW_VERSION: assert sensor.state == "Latest" elif name == google_wifi.ATTR_LOCAL_IP: - assert sensor.state == STATE_UNKNOWN + assert sensor.state is None else: assert sensor.state == "next" @@ -185,7 +184,7 @@ def test_when_api_data_missing(hass, requests_mock): sensor = sensor_dict[name]["sensor"] fake_delay(hass, 2) sensor.update() - assert sensor.state == STATE_UNKNOWN + assert sensor.state is None def test_update_when_unavailable(hass, requests_mock):