From 4684ea2d144621b6f66dcfd7da4ad0e1dfed0364 Mon Sep 17 00:00:00 2001 From: Erik Montnemery Date: Fri, 3 Sep 2021 10:13:35 +0200 Subject: [PATCH] Prevent 3rd party lib from opening sockets in broadlink tests (#55636) --- tests/components/broadlink/conftest.py | 11 +++++++++++ tests/components/broadlink/test_device.py | 8 -------- tests/components/broadlink/test_heartbeat.py | 9 --------- 3 files changed, 11 insertions(+), 17 deletions(-) create mode 100644 tests/components/broadlink/conftest.py diff --git a/tests/components/broadlink/conftest.py b/tests/components/broadlink/conftest.py new file mode 100644 index 00000000000..0a9ee4813da --- /dev/null +++ b/tests/components/broadlink/conftest.py @@ -0,0 +1,11 @@ +"""Broadlink test helpers.""" +from unittest.mock import patch + +import pytest + + +@pytest.fixture(autouse=True) +def mock_heartbeat(): + """Mock broadlink heartbeat.""" + with patch("homeassistant.components.broadlink.heartbeat.blk.ping"): + yield diff --git a/tests/components/broadlink/test_device.py b/tests/components/broadlink/test_device.py index 4ebfead007b..5430af9e311 100644 --- a/tests/components/broadlink/test_device.py +++ b/tests/components/broadlink/test_device.py @@ -2,7 +2,6 @@ from unittest.mock import patch import broadlink.exceptions as blke -import pytest from homeassistant.components.broadlink.const import DOMAIN from homeassistant.components.broadlink.device import get_domains @@ -16,13 +15,6 @@ from tests.common import mock_device_registry, mock_registry DEVICE_FACTORY = "homeassistant.components.broadlink.device.blk.gendevice" -@pytest.fixture(autouse=True) -def mock_heartbeat(): - """Mock broadlink heartbeat.""" - with patch("homeassistant.components.broadlink.heartbeat.blk.ping"): - yield - - async def test_device_setup(hass): """Test a successful setup.""" device = get_device("Office") diff --git a/tests/components/broadlink/test_heartbeat.py b/tests/components/broadlink/test_heartbeat.py index 5065bded881..de47a16c0b9 100644 --- a/tests/components/broadlink/test_heartbeat.py +++ b/tests/components/broadlink/test_heartbeat.py @@ -1,8 +1,6 @@ """Tests for Broadlink heartbeats.""" from unittest.mock import call, patch -import pytest - from homeassistant.components.broadlink.heartbeat import BroadlinkHeartbeat from homeassistant.util import dt @@ -13,13 +11,6 @@ from tests.common import async_fire_time_changed DEVICE_PING = "homeassistant.components.broadlink.heartbeat.blk.ping" -@pytest.fixture(autouse=True) -def mock_heartbeat(): - """Mock broadlink heartbeat.""" - with patch("homeassistant.components.broadlink.heartbeat.blk.ping"): - yield - - async def test_heartbeat_trigger_startup(hass): """Test that the heartbeat is initialized with the first config entry.""" device = get_device("Office")