evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid swallowing Roku errors (#72517)

Browse source
This commit is contained in:
Chris Talkington 2022-05-28 21:03:13 -05:00 • committed by GitHub
parent 7a0657c386
commit 46031aff8d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 47 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

17
homeassistant/components/roku/helpers.py
View file

@ -3,15 +3,14 @@ from __future__ import annotations
from collections.abc import Awaitable, Callable, Coroutine
from functools import wraps
import logging
from typing import Any, TypeVar
from rokuecp import RokuConnectionError, RokuConnectionTimeoutError, RokuError
from typing_extensions import Concatenate, ParamSpec
from .entity import RokuEntity
from homeassistant.exceptions import HomeAssistantError
_LOGGER = logging.getLogger(__name__)
from .entity import RokuEntity
_RokuEntityT = TypeVar("_RokuEntityT", bound=RokuEntity)
_P = ParamSpec("_P")
@ -43,14 +42,14 @@ def roku_exception_handler(
try:
await func(self, *args, **kwargs)
except RokuConnectionTimeoutError as error:
if not ignore_timeout and self.available:
_LOGGER.error("Error communicating with API: %s", error)
if not ignore_timeout:
raise HomeAssistantError(
"Timeout communicating with Roku API"
) from error
except RokuConnectionError as error:
if self.available:
_LOGGER.error("Error communicating with API: %s", error)
raise HomeAssistantError("Error communicating with Roku API") from error
except RokuError as error:
if self.available:
_LOGGER.error("Invalid response from API: %s", error)
raise HomeAssistantError("Invalid response from Roku API") from error
return wrapper