From 45f77ccccf5a22c1722680f05fac0ee96dd7f87b Mon Sep 17 00:00:00 2001 From: Franck Nijhof Date: Sat, 27 Mar 2021 09:23:32 +0100 Subject: [PATCH] Merge of nested IF-IF cases - Core (#48364) --- .../auth/mfa_modules/insecure_example.py | 16 +++++----------- homeassistant/helpers/area_registry.py | 7 ++----- homeassistant/setup.py | 9 +++++---- homeassistant/util/color.py | 9 ++++----- 4 files changed, 16 insertions(+), 25 deletions(-) diff --git a/homeassistant/auth/mfa_modules/insecure_example.py b/homeassistant/auth/mfa_modules/insecure_example.py index c25f70ca31b..1d40339417b 100644 --- a/homeassistant/auth/mfa_modules/insecure_example.py +++ b/homeassistant/auth/mfa_modules/insecure_example.py @@ -77,17 +77,11 @@ class InsecureExampleModule(MultiFactorAuthModule): async def async_is_user_setup(self, user_id: str) -> bool: """Return whether user is setup.""" - for data in self._data: - if data["user_id"] == user_id: - return True - return False + return any(data["user_id"] == user_id for data in self._data) async def async_validate(self, user_id: str, user_input: dict[str, Any]) -> bool: """Return True if validation passed.""" - for data in self._data: - if data["user_id"] == user_id: - # user_input has been validate in caller - if data["pin"] == user_input["pin"]: - return True - - return False + return any( + data["user_id"] == user_id and data["pin"] == user_input["pin"] + for data in self._data + ) diff --git a/homeassistant/helpers/area_registry.py b/homeassistant/helpers/area_registry.py index c181fadcfd3..aa9d3a40b9a 100644 --- a/homeassistant/helpers/area_registry.py +++ b/homeassistant/helpers/area_registry.py @@ -134,11 +134,8 @@ class AreaRegistry: normalized_name = normalize_area_name(name) - if normalized_name != old.normalized_name: - if self.async_get_area_by_name(name): - raise ValueError( - f"The name {name} ({normalized_name}) is already in use" - ) + if normalized_name != old.normalized_name and self.async_get_area_by_name(name): + raise ValueError(f"The name {name} ({normalized_name}) is already in use") changes["name"] = name changes["normalized_name"] = normalized_name diff --git a/homeassistant/setup.py b/homeassistant/setup.py index 4c5e10a254b..c22e660e553 100644 --- a/homeassistant/setup.py +++ b/homeassistant/setup.py @@ -315,10 +315,11 @@ async def async_prepare_setup_platform( log_error(f"Unable to import the component ({exc}).") return None - if hasattr(component, "setup") or hasattr(component, "async_setup"): - if not await async_setup_component(hass, integration.domain, hass_config): - log_error("Unable to set up component.") - return None + if ( + hasattr(component, "setup") or hasattr(component, "async_setup") + ) and not await async_setup_component(hass, integration.domain, hass_config): + log_error("Unable to set up component.") + return None return platform diff --git a/homeassistant/util/color.py b/homeassistant/util/color.py index f41461aada5..2a34fe82c59 100644 --- a/homeassistant/util/color.py +++ b/homeassistant/util/color.py @@ -261,11 +261,10 @@ def color_xy_brightness_to_RGB( vX: float, vY: float, ibrightness: int, Gamut: GamutType | None = None ) -> tuple[int, int, int]: """Convert from XYZ to RGB.""" - if Gamut: - if not check_point_in_lamps_reach((vX, vY), Gamut): - xy_closest = get_closest_point_to_point((vX, vY), Gamut) - vX = xy_closest[0] - vY = xy_closest[1] + if Gamut and not check_point_in_lamps_reach((vX, vY), Gamut): + xy_closest = get_closest_point_to_point((vX, vY), Gamut) + vX = xy_closest[0] + vY = xy_closest[1] brightness = ibrightness / 255.0 if brightness == 0.0: