From 42cdbc7e1d06955247ef4a8d5f25a92739cf0827 Mon Sep 17 00:00:00 2001 From: Andrew Marks Date: Mon, 9 Nov 2020 02:33:09 -0500 Subject: [PATCH] Correct logging and add test case for sharkiq (#41863) Co-authored-by: Martin Hjelmare --- homeassistant/components/sharkiq/update_coordinator.py | 5 ++++- tests/components/sharkiq/test_vacuum.py | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/homeassistant/components/sharkiq/update_coordinator.py b/homeassistant/components/sharkiq/update_coordinator.py index 0651d0765cf..eff18064dcc 100644 --- a/homeassistant/components/sharkiq/update_coordinator.py +++ b/homeassistant/components/sharkiq/update_coordinator.py @@ -74,7 +74,7 @@ class SharkIqUpdateCoordinator(DataUpdateCoordinator): SharkIqNotAuthedError, SharkIqAuthExpiringError, ) as err: - _LOGGER.exception("Bad auth state") + _LOGGER.debug("Bad auth state. Attempting re-auth", exc_info=err) flow_context = { "source": "reauth", "unique_id": self._config_entry.unique_id, @@ -87,6 +87,7 @@ class SharkIqUpdateCoordinator(DataUpdateCoordinator): ] if not matching_flows: + _LOGGER.debug("Re-initializing flows. Attempting re-auth") self.hass.async_create_task( self.hass.config_entries.flow.async_init( DOMAIN, @@ -94,6 +95,8 @@ class SharkIqUpdateCoordinator(DataUpdateCoordinator): data=self._config_entry.data, ) ) + else: + _LOGGER.debug("Matching flow found") raise UpdateFailed(err) from err except Exception as err: # pylint: disable=broad-except diff --git a/tests/components/sharkiq/test_vacuum.py b/tests/components/sharkiq/test_vacuum.py index e7255070eec..c548b59f5ba 100644 --- a/tests/components/sharkiq/test_vacuum.py +++ b/tests/components/sharkiq/test_vacuum.py @@ -4,7 +4,7 @@ import enum from typing import Any, Iterable, List, Optional import pytest -from sharkiqpy import AylaApi, SharkIqAuthError, SharkIqVacuum +from sharkiqpy import AylaApi, SharkIqAuthError, SharkIqNotAuthedError, SharkIqVacuum from homeassistant.components.homeassistant import SERVICE_UPDATE_ENTITY from homeassistant.components.sharkiq import DOMAIN @@ -217,6 +217,7 @@ async def test_locate(hass): [ (None, True), (SharkIqAuthError, False), + (SharkIqNotAuthedError, False), (RuntimeError, False), ], )