evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add icon translations to Melnor (#111906)

Browse source 
* Use default icon for Melnor

* Use default icon for Melnor
This commit is contained in:
Joost Lekkerkerker 2024-03-03 21:33:33 +01:00 • committed by GitHub
parent ec1400d392
commit 3c960b7d4e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 24 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

23
homeassistant/components/melnor/icons.json Normal file
View file

@ -0,0 +1,23 @@
{
"entity": {
"number": {
"manual_minutes": {
"default": "mdi:timer-cog-outline"
},
"frequency_interval_hours": {
"default": "mdi:calendar-refresh-outline"
},
"frequency_duration_minutes": {
"default": "mdi:timer-outline"
}
},
"switch": {
"manual": {
"default": "mdi:sprinkler"
},
"frequency": {
"default": "mdi:calendar-sync-outline"
}
}
}
}

3
homeassistant/components/melnor/number.py
View file

@ -46,7 +46,6 @@ ZONE_ENTITY_DESCRIPTIONS: list[MelnorZoneNumberEntityDescription] = [
entity_category=EntityCategory.CONFIG, entity_category=EntityCategory.CONFIG,
native_max_value=360, native_max_value=360,
native_min_value=1, native_min_value=1,
icon="mdi:timer-cog-outline",
key="manual_minutes", key="manual_minutes",
translation_key="manual_minutes", translation_key="manual_minutes",
native_unit_of_measurement=UnitOfTime.MINUTES, native_unit_of_measurement=UnitOfTime.MINUTES,
@ -57,7 +56,6 @@ ZONE_ENTITY_DESCRIPTIONS: list[MelnorZoneNumberEntityDescription] = [
entity_category=EntityCategory.CONFIG, entity_category=EntityCategory.CONFIG,
native_max_value=168, native_max_value=168,
native_min_value=1, native_min_value=1,
icon="mdi:calendar-refresh-outline",
key="frequency_interval_hours", key="frequency_interval_hours",
translation_key="frequency_interval_hours", translation_key="frequency_interval_hours",
native_unit_of_measurement=UnitOfTime.HOURS, native_unit_of_measurement=UnitOfTime.HOURS,
@ -68,7 +66,6 @@ ZONE_ENTITY_DESCRIPTIONS: list[MelnorZoneNumberEntityDescription] = [
entity_category=EntityCategory.CONFIG, entity_category=EntityCategory.CONFIG,
native_max_value=360, native_max_value=360,
native_min_value=1, native_min_value=1,
icon="mdi:timer-outline",
key="frequency_duration_minutes", key="frequency_duration_minutes",
translation_key="frequency_duration_minutes", translation_key="frequency_duration_minutes",
native_unit_of_measurement=UnitOfTime.MINUTES, native_unit_of_measurement=UnitOfTime.MINUTES,

3
homeassistant/components/melnor/switch.py
View file

@ -43,15 +43,14 @@ class MelnorSwitchEntityDescription(
ZONE_ENTITY_DESCRIPTIONS = [ ZONE_ENTITY_DESCRIPTIONS = [
MelnorSwitchEntityDescription( MelnorSwitchEntityDescription(
device_class=SwitchDeviceClass.SWITCH, device_class=SwitchDeviceClass.SWITCH,
icon="mdi:sprinkler",
key="manual", key="manual",
translation_key="manual",
name=None, name=None,
on_off_fn=lambda valve, bool: valve.set_is_watering(bool), on_off_fn=lambda valve, bool: valve.set_is_watering(bool),
state_fn=lambda valve: valve.is_watering, state_fn=lambda valve: valve.is_watering,
), ),
MelnorSwitchEntityDescription( MelnorSwitchEntityDescription(
device_class=SwitchDeviceClass.SWITCH, device_class=SwitchDeviceClass.SWITCH,
icon="mdi:calendar-sync-outline",
key="frequency", key="frequency",
translation_key="frequency", translation_key="frequency",
on_off_fn=lambda valve, bool: valve.set_frequency_enabled(bool), on_off_fn=lambda valve, bool: valve.set_frequency_enabled(bool),

3
tests/components/melnor/test_number.py
View file

@ -29,7 +29,6 @@ async def test_manual_watering_minutes(hass: HomeAssistant) -> None:
assert number.attributes["max"] == 360 assert number.attributes["max"] == 360
assert number.attributes["min"] == 1 assert number.attributes["min"] == 1
assert number.attributes["step"] == 1.0 assert number.attributes["step"] == 1.0
assert number.attributes["icon"] == "mdi:timer-cog-outline"
assert device.zone1.manual_watering_minutes == 0 assert device.zone1.manual_watering_minutes == 0
@ -65,7 +64,6 @@ async def test_frequency_interval_hours(hass: HomeAssistant) -> None:
assert number.attributes["max"] == 168 assert number.attributes["max"] == 168
assert number.attributes["min"] == 1 assert number.attributes["min"] == 1
assert number.attributes["step"] == 1.0 assert number.attributes["step"] == 1.0
assert number.attributes["icon"] == "mdi:calendar-refresh-outline"
assert device.zone1.frequency.interval_hours == 0 assert device.zone1.frequency.interval_hours == 0
@ -101,7 +99,6 @@ async def test_frequency_duration_minutes(hass: HomeAssistant) -> None:
assert number.attributes["max"] == 360 assert number.attributes["max"] == 360
assert number.attributes["min"] == 1 assert number.attributes["min"] == 1
assert number.attributes["step"] == 1.0 assert number.attributes["step"] == 1.0
assert number.attributes["icon"] == "mdi:timer-outline"
assert device.zone1.frequency.duration_minutes == 0 assert device.zone1.frequency.duration_minutes == 0

1
tests/components/melnor/test_switch.py
View file

@ -26,7 +26,6 @@ async def test_manual_watering_switch_metadata(hass: HomeAssistant) -> None:
assert switch is not None assert switch is not None
assert switch.attributes["device_class"] == SwitchDeviceClass.SWITCH assert switch.attributes["device_class"] == SwitchDeviceClass.SWITCH
assert switch.attributes["icon"] == "mdi:sprinkler"
async def test_manual_watering_switch_on_off(hass: HomeAssistant) -> None: async def test_manual_watering_switch_on_off(hass: HomeAssistant) -> None: