evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix of cover-tilt in homekit_controller (#91631)

Browse source 
* Fix of cover-tilt in homekit_controller

* Fix of cover-tilt and its tests
This commit is contained in:
badewanne1234 2023-05-25 12:41:42 +02:00 • committed by GitHub
parent 9231010402
commit 393dbb6dc0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 159 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

39
homeassistant/components/homekit_controller/cover.py
View file

@ -216,6 +216,26 @@ class HomeKitWindowCover(HomeKitEntity, CoverEntity):
tilt_position = self.service.value(
CharacteristicsTypes.HORIZONTAL_TILT_CURRENT
)
# Recalculate to convert from arcdegree scale to percentage scale.
if self.is_vertical_tilt:
scale = 0.9
if (
self.service[CharacteristicsTypes.VERTICAL_TILT_CURRENT].minValue == -90
and self.service[CharacteristicsTypes.VERTICAL_TILT_CURRENT].maxValue
== 0
):
scale = -0.9
tilt_position = int(tilt_position / scale)
elif self.is_horizontal_tilt:
scale = 0.9
if (
self.service[CharacteristicsTypes.HORIZONTAL_TILT_TARGET].minValue
== -90
and self.service[CharacteristicsTypes.HORIZONTAL_TILT_TARGET].maxValue
== 0
):
scale = -0.9
tilt_position = int(tilt_position / scale)
return tilt_position
async def async_stop_cover(self, **kwargs: Any) -> None:
@ -241,10 +261,29 @@ class HomeKitWindowCover(HomeKitEntity, CoverEntity):
"""Move the cover tilt to a specific position."""
tilt_position = kwargs[ATTR_TILT_POSITION]
if self.is_vertical_tilt:
# Recalculate to convert from percentage scale to arcdegree scale.
scale = 0.9
if (
self.service[CharacteristicsTypes.VERTICAL_TILT_TARGET].minValue == -90
and self.service[CharacteristicsTypes.VERTICAL_TILT_TARGET].maxValue
== 0
):
scale = -0.9
tilt_position = int(tilt_position * scale)
await self.async_put_characteristics(
{CharacteristicsTypes.VERTICAL_TILT_TARGET: tilt_position}
)
elif self.is_horizontal_tilt:
# Recalculate to convert from percentage scale to arcdegree scale.
scale = 0.9
if (
self.service[CharacteristicsTypes.HORIZONTAL_TILT_TARGET].minValue
== -90
and self.service[CharacteristicsTypes.HORIZONTAL_TILT_TARGET].maxValue
== 0
):
scale = -0.9
tilt_position = int(tilt_position * scale)
await self.async_put_characteristics(
{CharacteristicsTypes.HORIZONTAL_TILT_TARGET: tilt_position}
)