evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove connection status state. (#6475)

Browse source 
Current implementation of connection status doesn't follow convention and is not properly configurable. Might be added again in the future as a full fledged entity or some other way.

For now users can rely on error logging to determine connection status.
This commit is contained in:
Johan Bloemberg 2017-03-07 23:20:27 +01:00 • committed by Pascal Vizeli
parent d16bc632da
commit 3508f74fb2
2 changed files with 0 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
homeassistant/components/rflink.py
View file

@ -152,9 +152,6 @@ def async_setup(hass, config):
def connect(): def connect():
"""Set up connection and hook it into HA for reconnect/shutdown.""" """Set up connection and hook it into HA for reconnect/shutdown."""
_LOGGER.info('Initiating Rflink connection') _LOGGER.info('Initiating Rflink connection')
hass.states.async_set(
'{domain}.connection_status'.format(
domain=DOMAIN), 'connecting')
# Rflink create_rflink_connection decides based on the value of host # Rflink create_rflink_connection decides based on the value of host
# (string or None) if serial or tcp mode should be used # (string or None) if serial or tcp mode should be used
@ -180,9 +177,6 @@ def async_setup(hass, config):
_LOGGER.exception( _LOGGER.exception(
"Error connecting to Rflink, reconnecting in %s", "Error connecting to Rflink, reconnecting in %s",
reconnect_interval) reconnect_interval)
hass.states.async_set(
'{domain}.connection_status'.format(
domain=DOMAIN), 'error')
hass.loop.call_later(reconnect_interval, reconnect, exc) hass.loop.call_later(reconnect_interval, reconnect, exc)
return return
@ -195,9 +189,6 @@ def async_setup(hass, config):
lambda x: transport.close()) lambda x: transport.close())
_LOGGER.info('Connected to Rflink') _LOGGER.info('Connected to Rflink')
hass.states.async_set(
'{domain}.connection_status'.format(
domain=DOMAIN), 'connected')
hass.async_add_job(connect) hass.async_add_job(connect)
return True return True

4
tests/components/test_rflink.py
View file

@ -205,15 +205,11 @@ def test_error_when_not_connected(hass, monkeypatch):
_, mock_create, _, disconnect_callback = yield from mock_rflink( _, mock_create, _, disconnect_callback = yield from mock_rflink(
hass, config, domain, monkeypatch, failures=failures) hass, config, domain, monkeypatch, failures=failures)
assert hass.states.get('rflink.connection_status').state == 'connected'
# rflink initiated disconnect # rflink initiated disconnect
disconnect_callback(None) disconnect_callback(None)
yield from asyncio.sleep(0, loop=hass.loop) yield from asyncio.sleep(0, loop=hass.loop)
assert hass.states.get('rflink.connection_status').state == 'error'
success = yield from hass.services.async_call( success = yield from hass.services.async_call(
domain, SERVICE_TURN_OFF, {ATTR_ENTITY_ID: 'switch.test'}) domain, SERVICE_TURN_OFF, {ATTR_ENTITY_ID: 'switch.test'})
assert not success, 'changing state should not succeed when disconnected' assert not success, 'changing state should not succeed when disconnected'