evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Proper handling of authentication errors in AVM Fritz!Tools (#79434)

Browse source
This commit is contained in:
Michael 2023-02-01 16:03:18 +01:00 • committed by GitHub
parent afa55156d6
commit 2f51059b7f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 57 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

5
homeassistant/components/fritz/config_flow.py
View file

@ -9,7 +9,7 @@ from typing import Any
from urllib.parse import ParseResult, urlparse
from fritzconnection import FritzConnection
from fritzconnection.core.exceptions import FritzConnectionException, FritzSecurityError
from fritzconnection.core.exceptions import FritzConnectionException
import voluptuous as vol
from homeassistant.components import ssdp
@ -32,6 +32,7 @@ from .const import (
ERROR_CANNOT_CONNECT,
ERROR_UNKNOWN,
ERROR_UPNP_NOT_CONFIGURED,
FRITZ_AUTH_EXCEPTIONS,
)
_LOGGER = logging.getLogger(__name__)
@ -70,7 +71,7 @@ class FritzBoxToolsFlowHandler(ConfigFlow, domain=DOMAIN):
timeout=60.0,
pool_maxsize=30,
)
except FritzSecurityError:
except FRITZ_AUTH_EXCEPTIONS:
return ERROR_AUTH_INVALID
except FritzConnectionException:
return ERROR_CANNOT_CONNECT