From 2f1dba74d1254e2e575359f33e938fe070c801cc Mon Sep 17 00:00:00 2001 From: jjlawren Date: Wed, 24 Feb 2021 13:57:02 -0600 Subject: [PATCH] Use Plex server URL as config entry title (#47010) --- homeassistant/components/plex/config_flow.py | 2 +- tests/components/plex/test_config_flow.py | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/homeassistant/components/plex/config_flow.py b/homeassistant/components/plex/config_flow.py index e52e4597bf9..d611c09c43e 100644 --- a/homeassistant/components/plex/config_flow.py +++ b/homeassistant/components/plex/config_flow.py @@ -240,7 +240,7 @@ class PlexFlowHandler(config_entries.ConfigFlow, domain=DOMAIN): _LOGGER.debug("Valid config created for %s", plex_server.friendly_name) - return self.async_create_entry(title=plex_server.friendly_name, data=data) + return self.async_create_entry(title=url, data=data) async def async_step_select_server(self, user_input=None): """Use selected Plex server.""" diff --git a/tests/components/plex/test_config_flow.py b/tests/components/plex/test_config_flow.py index bc0e59e658f..bdd78131800 100644 --- a/tests/components/plex/test_config_flow.py +++ b/tests/components/plex/test_config_flow.py @@ -203,7 +203,7 @@ async def test_single_available_server(hass, mock_plex_calls): server_id = result["data"][CONF_SERVER_IDENTIFIER] mock_plex_server = hass.data[DOMAIN][SERVERS][server_id] - assert result["title"] == mock_plex_server.friendly_name + assert result["title"] == mock_plex_server.url_in_use assert result["data"][CONF_SERVER] == mock_plex_server.friendly_name assert ( result["data"][CONF_SERVER_IDENTIFIER] @@ -259,7 +259,7 @@ async def test_multiple_servers_with_selection( server_id = result["data"][CONF_SERVER_IDENTIFIER] mock_plex_server = hass.data[DOMAIN][SERVERS][server_id] - assert result["title"] == mock_plex_server.friendly_name + assert result["title"] == mock_plex_server.url_in_use assert result["data"][CONF_SERVER] == mock_plex_server.friendly_name assert ( result["data"][CONF_SERVER_IDENTIFIER] @@ -317,7 +317,7 @@ async def test_adding_last_unconfigured_server( server_id = result["data"][CONF_SERVER_IDENTIFIER] mock_plex_server = hass.data[DOMAIN][SERVERS][server_id] - assert result["title"] == mock_plex_server.friendly_name + assert result["title"] == mock_plex_server.url_in_use assert result["data"][CONF_SERVER] == mock_plex_server.friendly_name assert ( result["data"][CONF_SERVER_IDENTIFIER] @@ -656,7 +656,7 @@ async def test_manual_config(hass, mock_plex_calls): server_id = result["data"][CONF_SERVER_IDENTIFIER] mock_plex_server = hass.data[DOMAIN][SERVERS][server_id] - assert result["title"] == mock_plex_server.friendly_name + assert result["title"] == mock_plex_server.url_in_use assert result["data"][CONF_SERVER] == mock_plex_server.friendly_name assert result["data"][CONF_SERVER_IDENTIFIER] == mock_plex_server.machine_identifier assert result["data"][PLEX_SERVER_CONFIG][CONF_URL] == mock_plex_server.url_in_use @@ -692,7 +692,7 @@ async def test_manual_config_with_token(hass, mock_plex_calls): server_id = result["data"][CONF_SERVER_IDENTIFIER] mock_plex_server = hass.data[DOMAIN][SERVERS][server_id] - assert result["title"] == mock_plex_server.friendly_name + assert result["title"] == mock_plex_server.url_in_use assert result["data"][CONF_SERVER] == mock_plex_server.friendly_name assert result["data"][CONF_SERVER_IDENTIFIER] == mock_plex_server.machine_identifier assert result["data"][PLEX_SERVER_CONFIG][CONF_URL] == mock_plex_server.url_in_use